Repository navigation
chore: Simplify shared Roslyn worker internals - #1625
Conversation
Cover valid result headers and both invalid-header classifications before moving protocol parsing out of the worker host.
Move request framing, response parsing, protocol reads, and worker template rendering out of the process host. Pass the locked worker output reader explicitly so the protocol layer remains independent of host lifecycle state.
|
Warning Review limit reached
Next review available in: 17 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
No issues found across 4 files
You’re at about 92% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Summary
User Impact
Changes
SharedRoslynCompilerWorkerProtocolto own request encoding, response header parsing, diagnostic framing, protocol read timeout, quit marker, and worker program template token replacement.SharedRoslynCompilerWorkerHostfrom 988 to 865 lines while leaving retry, process lifecycle, assembly build, and shutdown state in the host.StandardOutputreader intoReadDiagnosticLines; all compile calls run underSharedCompilerWorkerLock, andProcess.StandardOutputreturns the same reader instance used for the response header.Path.GetFullPathapplication, blocking read behavior, strings, markers, timeout values, andout int exitCodecontract.Verification
dist/darwin-arm64/uloop compile --project-path "$(git rev-parse --show-toplevel)"(0 errors, 0 warnings)SharedRoslynCompilerWorkerHostTests(10 passed)ExternalCompilerPathResolverTests(15 passed, including worker-build fallback)StaticFacadeStateGuardTests(20 passed)