Skip to content

fix: Native CLI builds use the patched Go runtime - #1627

Merged
hatayama merged 1 commit into
v3-betafrom
chore/hatayama/upgrade-go-1-26-5
Jul 8, 2026
Merged

hatayama merged 1 commit into
v3-betafrom
chore/hatayama/upgrade-go-1-26-5

Conversation

@hatayama

@hatayama hatayama commented Jul 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Build the native CLI with Go 1.26.5 instead of Go 1.26.4.
  • Restore the Go CLI security scan after the publication of GO-2026-5856.

User Impact

  • Future native CLI builds use the patched crypto/tls standard library.
  • This removes the newly reported Encrypted Client Hello privacy leak from code paths that download dispatcher files over HTTPS.

Changes

  • Update the repository's patch-level Go toolchain source of truth in cli/.go-version.
  • Keep go.mod and go.work at go 1.26; they intentionally declare only the language/toolchain minor version.
  • No release-input stamps are required because cli/.go-version is outside the shared input trigger rules.

Verification

  • go version reports go1.26.5 darwin/arm64.
  • scripts/check-go-cli.sh passed for all Go modules and native dist verification.
  • scripts/test-go-cli-toolchain.sh passed.
  • govulncheck ./... reported No vulnerabilities found for cli/common, cli/dispatcher, cli/project-runner, and cli/release-automation.
  • Confirmed the previous security failure reproduced on the v3-beta base and was not caused by the concurrent C# refactor PR.

Review in cubic

Use the patched Go release that fixes GO-2026-5856 so CLI security scans and future native builds no longer use the vulnerable crypto/tls standard library.
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • cli/.go-version is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 449764c4-3f76-4925-a788-1d2378eb1fd3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/hatayama/upgrade-go-1-26-5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

You’re at about 93% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Re-trigger cubic

@hatayama
hatayama merged commit ed61757 into v3-beta Jul 8, 2026
10 checks passed
@hatayama
hatayama deleted the chore/hatayama/upgrade-go-1-26-5 branch July 8, 2026 16:30
RyanXie123 pushed a commit to RyanXie123/unity-cli-loop that referenced this pull request Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant