Repository navigation
refactor: extract mouse UI response construction - #1633
Conversation
Expose the existing response helpers at their final internal visibility and pin all current success, failure, timeout, bypass, hit, and no-hit response branches with synchronous EditMode tests before moving the implementation.
Move the six existing response-construction helpers into a stateless factory and switch the use case, validator, and characterization tests to direct calls. Preserve all response fields, messages, nullability, and timeout constants without retaining compatibility wrappers.
|
Warning Review limit reached
Next review available in: 28 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
No issues found across 6 files
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Summary
MouseUiSimulationResponseFactorySimulateMouseUiUseCasefrom 1,403 to 1,305 lines andMouseUiSimulationValidatorfrom 127 to 115 linesScope Notes
internal; this is their required final visibility because the use case remains a direct caller after extraction.CreateFailurewas alreadyinternalon the validator.privatetointernalchanges and blank lines. Conditions, messages, field assignments, nullability, and timeout constants are unchanged.Verification
dist/darwin-arm64/uloop compile(0 errors, 0 warnings)MouseUiSimulationResponseFactoryTestsbefore and after the move (12 passed)SimulateMouseUiTests(32 passed)SimulateMouseUiActionValidationTests(1 passed)PlayModeToolPreflightServiceTests(8 passed)StaticFacadeStateGuardTests(20 passed)OnionAssemblyDependencyTests(83 passed)git diff --check origin/v3-beta...HEAD