Skip to content

chore: remove unreachable mouse UI validation - #1644

Merged
hatayama merged 1 commit into
v3-betafrom
refactor/hatayama/remove-unreachable-bypass-validation
Jul 8, 2026
Merged

hatayama merged 1 commit into
v3-betafrom
refactor/hatayama/remove-unreachable-bypass-validation

Conversation

@hatayama

@hatayama hatayama commented Jul 8, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Remove a mouse UI validation branch that cannot be reached by any supported action.
  • Keep validation responses for every representable request unchanged.

User Impact

  • No user-visible behavior changes are intended.
  • Click, long press, one-shot drag, and split drag bypass behavior remains unchanged; unknown actions are still rejected before request-option validation.

Changes

  • Remove the unsupported-bypass failure branch from MouseUiSimulationValidator.
  • Remove its now-unreferenced SupportsBypassRaycast predicate.
  • Preserve target-path requirements, drag-button validation, drag-speed validation, drop-target validation, and their evaluation order.

Verification

  • Confirmed MouseAction contains exactly Click, LongPress, Drag, DragStart, DragMove, and DragEnd, all of which made the removed predicate true.
  • Confirmed schema conversion maps those six values and rejects unknown enum values before validator entry.
  • Confirmed the removed predicate and message have zero remaining references.
  • Unity compile: 0 errors, 0 warnings.
  • Focused Mouse UI EditMode fixtures: 30/30 passed.
  • Related preflight, assembly, source guard, and registry fixtures: 152/152 passed.
  • SimulateMouseUiTests PlayMode suite: 32/32 passed before and after deletion.
  • git diff --check: passed.

Compatibility

  • Remaining validation statements and wire-visible messages are unchanged.
  • No schema, public API, request/response shape, or protocol declaration changed.

Review in cubic

All representable mouse UI actions support bypass targeting, while unknown
actions are rejected before validation, so the defensive branch had no caller.
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8eeba66f-659e-45df-aa7b-845de8b75ab5

📥 Commits

Reviewing files that changed from the base of the PR and between 0b18b5e and 3b16e83.

📒 Files selected for processing (1)
  • Packages/src/Editor/FirstPartyTools/SimulateMouseUi/MouseUiSimulationValidator.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/hatayama/remove-unreachable-bypass-validation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit b164e25 into v3-beta Jul 8, 2026
10 checks passed
@hatayama
hatayama deleted the refactor/hatayama/remove-unreachable-bypass-validation branch July 8, 2026 23:49
RyanXie123 pushed a commit to RyanXie123/unity-cli-loop that referenced this pull request Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant