Repository navigation
fix: UI drag simulation now keeps mouse position in sync during drags - #1658
Conversation
…position Ports main commit fbe9cd4 (#1471) to v3-beta's split executor architecture. Click, LongPress, and both one-shot/incremental UI drags only updated PointerEventData, so UI handlers reading Mouse.current directly (rather than through PointerEventData) observed a stale position during simulation. Added MouseUiInputSystemSync.SyncMousePosition, wired into the five coordinate-update sites now split across MouseUiPressActionExecutor and MouseUiDragEventExecutor, reusing the existing InputSystemUpdateHelper / InputUpdateTypeResolver helpers from Common/InputSystem.
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Mouse.currentaligned with the simulated pointer position throughout the interaction.User Impact
Mouse.currentdirectly (instead of only throughPointerEventData) could observe a stale mouse position during simulated clicks and drags.Mouse.currentbehaves correctly during simulated UI interactions.Changes
MouseUiPressActionExecutor,MouseUiDragEventExecutor).MouseUiInputSystemSync.SyncMousePosition, reusing the existingInputSystemUpdateHelper/InputUpdateTypeResolverhelpers fromCommon/InputSystem.Verification
dist/darwin-arm64/uloop compile: successdist/darwin-arm64/uloop run-tests --test-mode PlayMode: 92/92 passed (including 2 new regression tests)dist/darwin-arm64/uloop run-tests --test-mode EditMode: 1726 passed, 0 failed, 7 skipped (pre-existing, unrelated)Refs: main commit fbe9cd4 (#1471), Stream B of the main→v3-beta port plan