Repository navigation
Conversation
Define the stable string values for single-shot, continuous, and trace pause point behavior so later registry and tool changes share one contract.
Extend pause point state with continuous and trace behavior plus bounded capture history while preserving single-shot defaults. Record frame-level evidence and retain history through clear and expiry so status consumers can inspect prior captures.
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughPause points now support single-shot, continuous, and trace capture modes. Captured variables are retained in bounded history frames with frame metadata, dropped-count tracking, lifecycle messages, and expanded snapshots. Editor tests cover mode behavior and lifecycle operations. ChangesPause-point capture behavior
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant Caller
participant UloopPausePointRegistry
participant UloopPausePointEntry
participant PauseController
Caller->>UloopPausePointRegistry: Enable capture mode and history limit
Caller->>UloopPausePointRegistry: Hit pause point with captured variables
UloopPausePointRegistry->>UloopPausePointEntry: Record hit and frame history
UloopPausePointRegistry->>PauseController: Pause unless mode is trace
UloopPausePointRegistry-->>Caller: Return snapshot with capture history
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Keep frame count capture inside the registry hit path, where main-thread execution is guaranteed, and make history snapshot allocation explicit at the call site.
This was referenced Jul 12, 2026
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
User Impact
Changes
Verification
dist/darwin-arm64/uloop compile --project-path "$(git rev-parse --show-toplevel)"dist/darwin-arm64/uloop run-tests --test-mode EditMode --filter-type regex --filter-value "PausePointCaptureModeTests"(7 passed)dist/darwin-arm64/uloop run-tests --test-mode EditMode --filter-type regex --filter-value "(PausePointTests|SourcePausePointCaptureTests)"(51 passed)