Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions Assets/Tests/Editor/ToolSettingsUseCaseTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,55 @@ public void ToolSettingsToolLinkPolicy_WhenAwaitPausePointRequested_IsNotUserFac
Is.EqualTo(UnityCliLoopConstants.SETTINGS_TOOL_NAME_PAUSE_POINT));
}

[Test]
public void TryGetToolCatalog_WhenRegistryAvailable_ExcludesWatchAuxiliaryTools()
{
// Verifies Tool Settings hides the watch tools because they belong to the pause-point family toggle.
IToolSettingsPort toolSettingsPort = new InMemoryToolSettingsPort();
UnityCliLoopToolRegistrarService toolRegistrarService = new(
new EmptyInternalToolNameProvider(),
toolSettingsPort,
new UnityCliLoopToolExecutionService(new NoOpEditorRuntimeStatePort()),
UnityCliLoopToolDiscovery.DiscoverTools);
ToolSettingsUseCase useCase = new(
toolSettingsPort,
toolRegistrarService,
new StaticToolSkillDescriptionProvider(new Dictionary<string, string>()));
useCase.WarmupRegistry();

bool isAvailable = useCase.TryGetToolCatalog(out ToolSettingsUseCase.ToolCatalogItem[] allTools);
string[] toolNames = allTools.Select(tool => tool.Name).ToArray();

Assert.That(isAvailable, Is.True);
Assert.That(toolNames, Does.Not.Contain(UnityCliLoopConstants.TOOL_NAME_ENABLE_WATCH));
Assert.That(toolNames, Does.Not.Contain(UnityCliLoopConstants.TOOL_NAME_CLEAR_WATCH));
Assert.That(toolNames, Does.Not.Contain(UnityCliLoopConstants.TOOL_NAME_GET_WATCH_VALUES));
}

[Test]
public void ToolSettingsToolLinkPolicy_WhenWatchToolRequested_IsNotUserFacingAndMapsToPausePoint()
{
// Verifies each watch tool is auxiliary and resolves to the pause-point settings key.
string[] watchToolNames =
{
UnityCliLoopConstants.TOOL_NAME_ENABLE_WATCH,
UnityCliLoopConstants.TOOL_NAME_CLEAR_WATCH,
UnityCliLoopConstants.TOOL_NAME_GET_WATCH_VALUES
};

foreach (string watchToolName in watchToolNames)
{
Assert.That(
ToolSettingsToolLinkPolicy.IsUserFacingToolSettingsTool(watchToolName),
Is.False,
watchToolName);
Assert.That(
ToolSettingsToolLinkPolicy.GetSettingsToolName(watchToolName),
Is.EqualTo(UnityCliLoopConstants.SETTINGS_TOOL_NAME_PAUSE_POINT),
watchToolName);
}
}

[Test]
public void TryGetToolCatalog_WhenSkillDescriptionExists_IncludesDescription()
{
Expand Down
5 changes: 4 additions & 1 deletion Packages/src/Editor/Domain/ToolSettingsToolLinkPolicy.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,10 @@ internal static class ToolSettingsToolLinkPolicy
UnityCliLoopConstants.COMMAND_NAME_AWAIT_PAUSE_POINT,
UnityCliLoopConstants.TOOL_NAME_ENABLE_PAUSE_POINT,
UnityCliLoopConstants.TOOL_NAME_CLEAR_PAUSE_POINT,
UnityCliLoopConstants.COMMAND_NAME_PAUSE_POINT_STATUS
UnityCliLoopConstants.COMMAND_NAME_PAUSE_POINT_STATUS,
UnityCliLoopConstants.TOOL_NAME_ENABLE_WATCH,
UnityCliLoopConstants.TOOL_NAME_CLEAR_WATCH,
UnityCliLoopConstants.TOOL_NAME_GET_WATCH_VALUES
};

internal static bool IsUserFacingToolSettingsTool(string toolName)
Expand Down
Loading