Repository navigation
ci: stop release-please from running on main - #2131
Merged
Merged
Conversation
The v2 series is no longer released, so the automatic release PR for 2.3.0 is pure noise. Closing it does not stick: release-please recreates it on the next push to main (#2095 was closed and came back as #2099). Removing only the branch entry would leave an empty `branches:`, which matches every branch, so the whole push trigger is removed instead. Manual runs via workflow_dispatch (branch=main) still work if a v2 release becomes necessary again.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow now runs only through manual ChangesRelease Workflow
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v2 series is no longer released, so the automatic release PR for 2.3.0 is pure noise.
Closing it does not stick. release-please recreates it on the next push to
main— #2095 was closed and came back as #2099, with identical contents.What changes
The
pushtrigger is removed from.github/workflows/release-please.ymlonmain.Removing only the
- mainentry would leave an emptybranches:, which matches every branch, so the wholepushtrigger goes instead.What still works
workflow_dispatchremains, so a v2 release can still be produced manually (branch=main). The job that dispatchesnpm-publish.ymlafter a successful release is downstream of that, so the chain is intact for manual runs.v3-betais unaffected: pushes to that branch are matched by the workflow definition onv3-beta, which is a separate file.Reverting
Restore the
push:block. One edit, no state to unwind.Follow-up
#2099 will be closed after this merges. Closing it before the merge would let the next push to
mainrecreate it.Summary
pushtrigger formainfrom.github/workflows/release-please.yml.workflow_dispatchwithbranch=main.npm-publish.ymldispatch.v3-betaworkflow unchanged.#2099should be closed after this PR merges.