Repository navigation
fix: explain pause-point truncation flags filtered by captured-variable names - #2290
Merged
Merged
Conversation
…le names When --captured-variable-names drops a clipped variable, CapturedVariablesTruncated stayed true with Count 0 and no truncated survivors. Keep the flag and add a CLI note so agents can tell every listed value is complete. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pause-point response now includes an optional ChangesPause-point capture truncation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add negative cases for a false truncation flag and a history-only truncated survivor, and assert the note against a production-independent literal so a wording change fails. Co-authored-by: Cursor <cursoragent@cursor.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CapturedVariablesTruncatedstays true after--captured-variable-namesdrops every clipped variable.User Impact
--captured-variable-namescould returnCapturedVariablesTruncated: truewithTruncatedVariableCount: 0andTruncatedVariableNames: []even though every remaining variable was complete, so agents could not tell whether the values they asked for were clipped.CapturedVariablesTruncatedNotein that case: the truncation flag refers to a variable excluded by the name filter, and every listed variable is complete.Changes
CapturedVariablesTruncated == true,TruncatedVariableCount == 0, and no remaining truncated variables, then setCapturedVariablesTruncatedNote(omitempty).CapturedVariablesTruncated.pause_point_status_response_contract.jsonis unchanged (omitemptykeeps the CLI-only note off Unity payloads).Verification
scripts/check-go-cli.shpassed (format, vet, lint, tests, rebuild), including:TestFilterPausePointCapturedVariablesByNameSetsTruncatedNote(note set / omitted / no filter / count-cap)TestUnityPausePointStatusContractTruncationInvariantTestPausePointStatusResponseMatchesSharedContractgit diff -- tests/contracts/pause_point_status_response_contract.jsonis empty