Repository navigation
feat: note symbol-less caller frames in pause-point responses - #2298
Conversation
File and Line omissions had three causes that looked identical on the wire. Name the cause on Note so a missing debug-symbol path is not labeled as outside the project. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (16)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughCaller-frame handling now reports why file and line data are absent. Notes identify dynamic methods, missing debug symbols, and source files outside the project. The notes propagate through runtime, editor status, and CLI JSON models with test coverage. ChangesCaller-frame diagnostic notes
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR adds explanatory notes for symbol-less pause-point caller frames and propagates them through the response contracts without a current merge-blocking risk; it is merge-ready after normal checks and review. Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
File/Linenow include aNotethat names why those fields are missing.User Impact
Noteinstead of treating every missing path as "outside the project".Changes
FileNameis classified before path normalization.Note(NullValueHandling.Ignore). Go mirrorsNotewithomitempty. The shared status contract fixture is unchanged.Verification
scripts/check-go-cli.shpassuloop compile: Success, ErrorCount: 0PausePointCallerFrameSelectorTests|PausePointStatusCallerFrameTests|PausePointStatusResponse_WhenSerialized: 49 passed