Repository navigation
chore: Dispatcher pin freshness gate now runs on pushes to main and on a daily schedule - #2475
Conversation
build-and-test.yml only runs on tag pushes, pull requests, and manual dispatch, so the step added there in #2474 never executed on a push to main and the lagging-pin gate was effectively inert. Give the check its own workflow triggered by pushes to main, a daily schedule (a release can be published without any later push), and workflow_dispatch.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe change moves dispatcher pin freshness checks from the build workflow to a dedicated workflow. The new workflow runs on main pushes, daily schedules, and manual dispatches. Documentation describes the triggers and remediation paths. ChangesDispatcher Pin Freshness
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change moves the dispatcher pin freshness check into a workflow that runs on pushes to main, daily, and manually, while preserving the existing failure behavior. No actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant dispatcher_pin_freshness_workflow
participant check_dispatcher_pin_freshness
GitHubActions->>dispatcher_pin_freshness_workflow: Trigger on main push, schedule, or manual dispatch
dispatcher_pin_freshness_workflow->>check_dispatcher_pin_freshness: Run command with GITHUB_TOKEN
check_dispatcher_pin_freshness->>GitHubActions: Report pin freshness result
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Follow-up to #2474 (issue #2463).
Summary
main: it moves frombuild-and-test.yml, which never runs on branch pushes, into its own workflow triggered by pushes tomain, a daily schedule, and manual dispatchUser Impact
build-and-test.ymlunderif: github.event_name != 'pull_request', but that workflow'spushtrigger is tag-only (v*,uloop-project-runner-v*,dispatcher-v*), so the gate would only ever have run on a manual dispatch. A lagging pin would still have gone unnoticed onmain— the exact gap Automate dispatcher pin stamping after a stable dispatcher release #2463 set out to closeDispatcher Pin Freshnessruns on every push tomain, once a day (so a release published without a later push is still caught), and on demand. It fails with the same message as before whiledispatcherReleaseTaglags the newest stable releaseChanges
.github/workflows/dispatcher-pin-freshness.yml(new): checkout +setup-go(cache: false) +go run ./cmd/check-dispatcher-pin-freshness;contents: readonly; action SHAs reused from existing workflows.github/workflows/build-and-test.yml: the misplaced step removeddocs/dispatcher-pin-release-order.md: names the new workflow and why it also runs on a scheduleVerification
actionlinton both workflows: cleango run ./cmd/check-dispatcher-pin-freshnessfromcli/release-automationagainst the live repository still passes for the current pin (dispatcher-v3.0.1)https://claude.ai/code/session_01XbhSMKK4LFud57iAmowDz7