Repository navigation
fix: simulate-keyboard press-edge diagnostics no longer report a missing gameplay update on Fixed/Manual input projects - #2532
Merged
Conversation
Contributor
|
Warning Review limit reachedNext included review available in 8 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
simulate-keyboardpress-edge miss diagnostics now recogniseFixedandManualInput System updates as gameplay updates, so projects that do not process input inDynamicupdates no longer get a misleading "no gameplay update ran" verdict.User Impact
PressEdgeAnyDynamicUpdateObservedwastrueonly if aDynamicupdate ran. On a project whose Input System update mode isProcessEventsInFixedUpdateorProcessEventsManually, the flag came backfalseand the message said no update ran, even though the project's gameplay updates did run. The suggested next action ("check that PlayMode is running and unpaused") then sent the agent down the wrong path.PressEdgeAnyGameplayUpdateObservedand istruewhen anyDynamic,Fixed, orManualupdate ran during the press window.Editorticks still do not count. The diagnostic text and the skill reference table describe the same rule.Changes
InputUpdateTypeResolver.IsGameplayUpdateclassifiesDynamic/Fixed/Manualas gameplay updates. Both the edge visibility check and the miss diagnostics use it, so they cannot disagree again.PressEdgeAnyGameplayUpdateObserved; diagnostic suffix reworded.output.mdupdated (and its generated.claude/and.agents/copies regenerated); the "consumed by" row now namesEditorexplicitly instead of "non-Dynamic".InputUpdateTypeResolverTests; formatter and response-contract tests updated.Verification
uloop run-tests --filter-type regex --filter-value "InputUpdateTypeResolverTests|PressEdgeDiagnosticsMessageFormatterTests|SimulateKeyboardResponseContractTests": 12 passed, 0 failed (compile ran first, 0 errors).check-skill-size: no SKILL.md over the limit.Refs #2425
https://claude.ai/code/session_01R3jkx6NbNYKPdy5q1NSWYo
https://claude.ai/code/session_01R3jkx6NbNYKPdy5q1NSWYo