Repository navigation
fix(pause-point): abort on synchronous trigger rejection and key expired guidance on MethodEntryCount #2587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
16a21bd
fix(pause-point): abort the wait when Unity rejects the trigger befor…
hatayama 21cb0f1
fix(pause-point): lead the non-firing diagnosis with the event never …
hatayama b474dd0
fix(pause-point): report a pre-execution refusal as a structured resp…
hatayama d01c8b7
fix(pause-point): lead expired guidance with the awaited event, not c…
hatayama 44e12ab
fix(pause-point): offer the trigger-free await in the enable arming g…
hatayama b9afc65
fix(pause-point): stop blaming the trigger value for a Unity-side ref…
hatayama a9c0b2a
fix(pause-point): stop the non-firing hint from assuming a trigger fired
hatayama 747d588
fix(pause-point): quote the real dispatch failure instead of assertin…
hatayama cdb00a3
fix(pause-point): write the arming hint's one-call form as a runnable…
hatayama e326e59
docs(pause-point): state the one refusal that does not abort the trig…
hatayama 81f19c5
test(pause-point): drive the preflight rejection through each tool's …
hatayama 2cfcbeb
fix(pause-point): stop asserting the method never ran when the patch …
hatayama 41f0dea
fix(pause-point): stop asking for a corrected trigger command Unity n…
hatayama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.