Repository navigation
chore: Update the launch comment about how V3 schedules server recovery - #3172
Conversation
The comment pointed at a SignalTick call, by line number, that V3 no longer makes: V3 now queues its recovery on the main-thread dispatcher, which drains on update and tick and signals a tick when work is enqueued. Name the recovery method instead of line numbers so the reference does not go stale again. No code changes.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review. 📝 WalkthroughWalkthroughThe V2 launch focus comment now states that ChangesLaunch focus behavior
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The clarification does not change launch behavior, and no merge-blocking issue was identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The stall was measured in one setup, so the comment should not claim that delayCall never runs in any unfocused Editor.
Summary
User Impact
SignalTickcall, cited by file and line numbers) that V3 has since removed. Anyone following the reference found code that no longer exists.Changes
EditorApplication.delayCall, which was observed not to run while the Editor window is unfocused. V3 now queues its recovery on the main-thread dispatcher, which drains on update and tick and signals a tick when work is enqueued. V2 has no equivalent, so the launch still focuses the Editor once.UnityCliLoopServerController.OnServerLoopUnexpectedlyExitedinstead of line numbers.Verification
scripts/check-go-cli.shstops in the local sandbox at an existingcli/commontest that needs to create a folder under/tmp, unrelated to this change. In its place,cli/dispatcherpassesgofmt -l(no files),go vet ./...,go build ./...,golangci-lint fmt --diff,golangci-lint run(0 issues), andgo test ./.... CI runs the full check.