Repository navigation
chore: Align two hot-reload test pins with the unresolved signature type skip reason - #3180
Merged
hatayama merged 1 commit intoOct 6, 2026
Conversation
An added method whose signature names a type the compilation cannot resolve now reports that it could not resolve the named type, so the two tests that still expected the older "could not be resolved" wording failed. They now pin the current wording and the name of the unresolved type.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hatayama
merged commit Oct 6, 2026
61c1764
into
feature/hot-reload-large-project-feedback
1 of 2 checks passed
hatayama
deleted the
fix/hot-reload-unresolved-signature-type-test-pins
branch
October 6, 2026 08:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TransformWorkerAddedMemberTeststests fail on the integration branch since fix: Hot reload applies edits to methods using types from another file's global using, and names unresolved signature types #3179 changed the skip reason for an added method whose signature names a type the compilation cannot resolve. They still pinned the older wording "could not be resolved".Changes
Run_AddedMethodReturningUnresolvedType_WithPrivateAccess_ReportsUnresolvedTypeNotVisibilityandRun_AddedMethodReturningListOfUnresolvedType_ReportsUnresolvedTypeNotVisibilitynow expect "could not resolve" and the quoted name of the unresolved type ('MissingReturnType'and'MissingType').Verification
Before the change, both tests failed on the integration branch head with:
After the change:
uloop run-tests --filter-type class --filter-value TransformWorkerAddedMemberTests: 73 tests, 73 passed.This PR targets an integration branch, so the build-and-test workflow does not run on it.