Skip to content

chore: Align two hot-reload test pins with the unresolved signature type skip reason - #3180

Merged
hatayama merged 1 commit into
feature/hot-reload-large-project-feedbackfrom
fix/hot-reload-unresolved-signature-type-test-pins
Oct 6, 2026
Merged

hatayama merged 1 commit into
feature/hot-reload-large-project-feedbackfrom
fix/hot-reload-unresolved-signature-type-test-pins

Conversation

@hatayama

@hatayama hatayama commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Summary

Changes

  • Run_AddedMethodReturningUnresolvedType_WithPrivateAccess_ReportsUnresolvedTypeNotVisibility and Run_AddedMethodReturningListOfUnresolvedType_ReportsUnresolvedTypeNotVisibility now expect "could not resolve" and the quoted name of the unresolved type ('MissingReturnType' and 'MissingType').
  • The check that the reason is not the visibility one (condition c) stays.

Verification

  • Before the change, both tests failed on the integration branch head with:

    Expected: String containing "could not be resolved"
    But was: "The method signature names a type the hot-reload compilation could not resolve ('MissingType'), so hot reload cannot tell whether this method already exists in the compiled assembly. ..."

  • After the change: uloop run-tests --filter-type class --filter-value TransformWorkerAddedMemberTests: 73 tests, 73 passed.

    • This ran on another branch based on the same integration branch head. That branch differs from this one only in files these tests and the skip reason do not use.
    • This branch's commit is that commit replayed onto the integration branch head, and the test file is byte-identical to the one that ran.
  • This PR targets an integration branch, so the build-and-test workflow does not run on it.

Review in cubic

An added method whose signature names a type the compilation cannot resolve
now reports that it could not resolve the named type, so the two tests that
still expected the older "could not be resolved" wording failed. They now pin
the current wording and the name of the unresolved type.
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: hatayama/unity-cli-loop/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 77f8040a-7220-41c7-91cb-3e25be27ee58
📥 Commits

Reviewing files that changed from the base of the PR and between eff5a47 and 4e6b54d.

📒 Files selected for processing (1)
  • Assets/Tests/Editor/HotReload/TransformWorkerAddedMemberTests.cs
 ______________________________________________________
< Review complete: I laughed, I cried, I filed issues. >
 ------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit 61c1764 into feature/hot-reload-large-project-feedback Oct 6, 2026
1 of 2 checks passed
@hatayama
hatayama deleted the fix/hot-reload-unresolved-signature-type-test-pins branch October 6, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant