Skip to content

fix: Hot reload now says to run uloop compile when an added member uses a name generated at compile time #3193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hatayama merged 2 commits into from
Oct 6, 2026
Merged

fix: Hot reload now says to run uloop compile when an added member uses a name generated at compile time #3193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
084db93
Expect the unbound added-member reason to point generated names to a …
hatayama Oct 6, 2026
9b837ee
Point generated names to a compile in the unbound added-member reason
hatayama Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Assets/Tests/Editor/HotReload/HotReloadWorkerReasonTextTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,9 @@ private static IEnumerable<TestCaseData> RenderCases()
"The added member's body could not be fully bound in the hot-reload compilation "
+ "(CS1503: Argument 1: cannot convert); hot reload cannot verify a member it cannot bind, "
+ "so it is skipped. If the name is declared in a new file, pass that file to --files too "
+ "(new files are not selected automatically); run 'uloop compile' only if it still does not bind.");
+ "(new files are not selected automatically). If the name is generated at compile time, "
+ "for example by a source generator, hot reload cannot see it: run 'uloop compile'. "
+ "Also run 'uloop compile' if it still does not bind.");
yield return Case(
HotReloadWorkerReasonCode.AddedMethodBodyBindsCompiledSignature,
new[] { "CS1503: Argument 1: cannot convert", "'Example.Payload'", "'Example.Registry'", "'Assets/Registry.cs'" },
Expand Down
4 changes: 3 additions & 1 deletion ...Editor/FirstPartyTools/HotReload/Shared/HotReloadWorkerReasonText.AddedMemberTemplates.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@ private static void AddAddedMemberTemplates(
"The added member's body could not be fully bound in the hot-reload compilation ({0}); "
+ "hot reload cannot verify a member it cannot bind, so it is skipped. If the name is "
+ "declared in a new file, pass that file to --files too (new files are not selected "
+ "automatically); run 'uloop compile' only if it still does not bind.",
+ "automatically). If the name is generated at compile time, for example by a source "
+ "generator, hot reload cannot see it: run 'uloop compile'. Also run 'uloop compile' if "
+ "it still does not bind.",
1));
// Why the next step is not worded here: which step works (pass the file, leave it
// out, undo the edit and leave it out, or compile) depends on how the file entered the
Expand Down
Loading