Repository navigation
fix: Pause point status, await, and clear find a marker in a local package folder outside Packages - #3223
Merged
hatayama merged 1 commit intoOct 7, 2026
Conversation
A local package referenced with file: can live inside the project root but outside Packages/. A query naming its script by that project-relative folder path was taken for an asset path and skipped, so status reported NotEnabled while enable accepted the same path. Only a plain Assets/ path now skips the package roots; every other path is mapped through them. The roots are passed in as a deferred read so the skip still avoids the Package Manager on every await poll.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hatayama
merged commit Oct 7, 2026
e208b53
into
feature/hot-reload-large-project-feedback-2
4 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pause-point-status,await-pause-point, andclear-pause-pointnow also find a marker when--filenames a script of a local package (referenced withfile:) whose folder sits inside the project but outsidePackages/. Example:LocalPackages/foo/Runtime/X.cs.User Impact
enable-pause-point --file LocalPackages/foo/Runtime/X.cs --line 3set the markerPackages/<package-id>/Runtime/X.cs:3. The same--fileinpause-point-statuswas taken for an asset path and looked up as given, so it reportedNotEnabled. With a./prefix it worked.Changes
Assets/and has no\,.segment, or..segment. Any other project-relative path may be a package folder, underPackages/or elsewhere in the project, so it is mapped through the package roots.SourcePausePointId.ToMarkerIdas a deferred read (ScriptPackageRoots.ReadCurrent). The status bridge and the clear tool pass the same read as before. A plainAssets/path still never reaches the Package Manager on the status poll thatawaitrepeats every second.Input space
LocalPackages/foo/Runtime/X.cs:3(folder inside the project, outsidePackages/)Packages/com.example.foo/Runtime/X.cs:3ToMarkerId_FolderPathOfAPackageOutsidePackagesFolder_RewritesToTheAssetPathAssets/X.cs:3ToMarkerId_AssetsPath_ReturnsItWithoutReadingPackageRootsPackages/com.example.foo/Runtime/X.cs:3(already the asset path)ToMarkerId_PackageAssetPath_ReturnsItUnchangedPausePointQueryScriptPathFormTests(13, unchanged)Verification
Repository CI does not run on pull requests into this integration branch. Everything below was run locally against a running Editor.
Compile:
uloop compilereports 0 errors.Before the fix: only the folder-path test failed (it got
LocalPackages/foo/Runtime/X.cs:3back).Tests: I ran
uloop run-testsone class at a time. All passed:SourcePausePointIdTestsPausePointQueryScriptPathFormTestsPausePointScriptPathFormTestsPausePointTestsMutations (each compiled, then
SourcePausePointIdTestsandPausePointQueryScriptPathFormTestsrun):ToMarkerId_AssetsPath_ReturnsItWithoutReadingPackageRootsfailsToMarkerId_FolderPathOfAPackageOutsidePackagesFolder_RewritesToTheAssetPathfailsStatic checks: all exit 0.