Repository navigation
test: Expect the shared script path assembly among the Infrastructure references - #3225
Merged
hatayama merged 1 commit intoOct 7, 2026
Conversation
…ences The pause point status bridge maps a query's script path through the shared script path assembly since the any-path-form lookup change, but the onion dependency test still pinned the old reference list, so the scheduled EditMode suite failed.
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hatayama
merged commit Oct 7, 2026
ef9991c
into
feature/hot-reload-large-project-feedback-2
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InfrastructureAsmdef_WhenLoaded_DependsOnApplicationRuntimeAndDoesNotReferencePresentationpinned the Infrastructure assembly's references, and fix: Pause point status, await, and clear find a marker whichever path names the file #3220 addedUnityCLILoop.FirstPartyTools.Common.ScriptPath.Editorto them.Changes
OnionAssemblyDependencyTestsgains aCommonScriptPathAssemblyNameconstant and expects it among the Infrastructure references.Verification
Repository CI does not run on pull requests into this integration branch. Everything below was run locally against a running Editor.
Before the fix, on e208b53:
OnionAssemblyDependencyTestsfailed 1 of 83 tests, this one. It reported the same "Expected: equivalent to" list as the scheduled run.After the fix: compile reports 0 errors, and
OnionAssemblyDependencyTestspasses 83 of 83.Other tests that pin assembly references or read the touched asmdefs also pass:
StaticFacadeStateGuardTestsUnityCliLoopToolRegistryTests