Skip to content

test: Expect the shared script path assembly among the Infrastructure references - #3225

Merged
hatayama merged 1 commit into
feature/hot-reload-large-project-feedback-2from
test/onion-infrastructure-references-script-path
Oct 7, 2026
Merged

hatayama merged 1 commit into
feature/hot-reload-large-project-feedback-2from
test/onion-infrastructure-references-script-path

Conversation

@hatayama

@hatayama hatayama commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Summary

Changes

  • OnionAssemblyDependencyTests gains a CommonScriptPathAssemblyName constant and expects it among the Infrastructure references.
  • The test's comment now says the infrastructure maps a pause point query's script path through the shared script path mapping.
  • No production code changes.

Verification

Repository CI does not run on pull requests into this integration branch. Everything below was run locally against a running Editor.

Before the fix, on e208b53: OnionAssemblyDependencyTests failed 1 of 83 tests, this one. It reported the same "Expected: equivalent to" list as the scheduled run.

After the fix: compile reports 0 errors, and OnionAssemblyDependencyTests passes 83 of 83.

Other tests that pin assembly references or read the touched asmdefs also pass:

Class Tests
StaticFacadeStateGuardTests 20
UnityCliLoopToolRegistryTests 38

Review in cubic

…ences

The pause point status bridge maps a query's script path through the shared script path assembly since the any-path-form lookup change, but the onion dependency test still pinned the old reference list, so the scheduled EditMode suite failed.
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: hatayama/unity-cli-loop/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5c0d2628-ceec-46d3-a19f-8f0200f3ecd4
📥 Commits

Reviewing files that changed from the base of the PR and between e208b53 and 57e85ef.

📒 Files selected for processing (1)
  • Assets/Tests/Editor/OnionAssemblyDependencyTests.cs
 _____________________________________
< Please step away from the keyboard! >
 -------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit ef9991c into feature/hot-reload-large-project-feedback-2 Oct 7, 2026
1 of 2 checks passed
@hatayama
hatayama deleted the test/onion-infrastructure-references-script-path branch October 7, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant