Run integration tests through the oha binary and simplify test setup - #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration tests previously called
oha::runthrough a library target, bypassing the executable's entry point. Run the Cargo-built binary viaCARGO_BIN_EXE_ohainstead, capturing its exit status and output for failure diagnostics. Move the implementation intomain.rsand retain argument-parsing checks as unit tests.The integration tests now use current-thread Tokio runtimes. Simplify argument handling with
AsRef<OsStr>, merge the proxy helpers, and parameterize JSON schema validation. Bind TCP and QUIC servers to OS-assigned ports while retaining their sockets, and embed the HTTP/3 test certificates withinclude_bytes!.Validation on Linux:
main.rs.cargo fmt --all --checkcargo clippy --all-targets --all-features -- -D warnings