Repository navigation
feat!: settle the public contract before 1.0 - #48
Merged
Merged
Conversation
The site never read them and nothing checked them against the editions, so they could drift. Editions already say where each one takes place, including every city a touring convention visits. BREAKING CHANGE: convention records no longer have `city` or `region`. Read them from the convention's editions instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last review of the public contract before 1.0 (ROADMAP, 2026-10-20): every page and feed URL pattern, the id rules and every field in
data/README.md.Changed
cityandregion. The site never read them and nothing checked them against the editions. The 35 convention records were approved and promoted; the schema now rejects the fields.data/README.mdlists every field, the id rules (including a second edition in the same city and year), and that published records are never renamed or deleted.Kept
feeds/north.ics) and region page slugs (/regions/north-texas/) stay as they are; renaming would break subscribers or links./calendar/YYYY-MM/) are a rolling window, outside the stable contract.Moving
Breaking changes for the v1.0.0 notes: convention records no longer have
cityorregion; read them from the editions.Checked locally: 85 unit tests, 152 e2e tests, typecheck, lint,
data:validate.Closes #38