Repository navigation
feat(core): check field order instead of adding data:format - #49
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prettier already formats
data/and CI fails on its layout, and every record already lists its fields in schema order, so apnpm data:formatcommand would have had almost nothing to rewrite.Instead, loading a record warns when its fields stray from schema order, naming the order to use:
It shows up in
pnpm data:validateandpnpm data:diff, so a draft is caught before it's published. The record still loads; it's a warning, not an error.packages/core/src/load.ts: the check, comparing each raw record with its parsed form (which lists fields in schema order), nested objects includeddata/README.md: write fields in the order the tables list themROADMAP.md: the decision, dated 2026-10-20pnpm data:validateon the current data: 0 errors, 0 warnings.Closes #11