Skip to content

Fix App Management permission loop - #12

Merged
hewigovens merged 1 commit into
mainfrom
codex/fix-app-management-permission-loop
May 17, 2026
Merged

Fix App Management permission loop#12
hewigovens merged 1 commit into
mainfrom
codex/fix-app-management-permission-loop

Conversation

@hewigovens

@hewigovens hewigovens commented May 17, 2026

Copy link
Copy Markdown
Owner

Summary

From #10.

This corrects the App Management permission preflight check so GhostTile treats TCCAccessPreflight result 0 as granted. The previous logic interpreted the result backwards, which could keep showing the App Management alert even after the user had granted permission.

This also bumps the app release metadata to 2.0.7 (24) and adds the releases/2.0.7.html release-note fragment for the patch build.

Changes

  • Corrected AppManagementPermissionStatusReader to map preflight result 0 to allowed.
  • Added GhostTileAppTests coverage for the preflight result mapping.
  • Bumped app version/build from 2.0.6 (23) to 2.0.7 (24).
  • Added release notes for 2.0.7.

Impact

Users who already granted App Management permission should no longer get stuck in the repeated authorization prompt loop. The app still falls back to the existing guidance flow when permission is missing or cannot be read.

Validation

  • just format
  • just lint (passes with existing unrelated warnings)
  • swift test
  • just build
  • codesign --verify --deep --strict --verbose=2 GhostTile.app

@hewigovens
hewigovens marked this pull request as ready for review May 17, 2026 06:07
@hewigovens hewigovens changed the title [codex] Fix App Management permission loop Fix App Management permission loopf May 17, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new test target, GhostTileAppTests, and refactors the AppManagementPermissionStatusReader to extract the permission validation logic into a testable isAllowed method. This refactoring also adjusts the logic to correctly interpret a successful preflight result as 0. A review comment identifies a potential build issue where the Testing framework is used without ensuring the Package.swift tools version or dependencies support it.

@hewigovens
hewigovens force-pushed the codex/fix-app-management-permission-loop branch from c90c329 to 1cd3885 Compare May 17, 2026 06:22
@hewigovens hewigovens changed the title Fix App Management permission loopf Fix App Management permission loop May 17, 2026
@hewigovens
hewigovens merged commit dd7adc9 into main May 17, 2026
1 check passed
@hewigovens
hewigovens deleted the codex/fix-app-management-permission-loop branch May 17, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant