Fix App Management permission loop - #12
Merged
Merged
Conversation
hewigovens
marked this pull request as ready for review
May 17, 2026 06:07
There was a problem hiding this comment.
Code Review
This pull request introduces a new test target, GhostTileAppTests, and refactors the AppManagementPermissionStatusReader to extract the permission validation logic into a testable isAllowed method. This refactoring also adjusts the logic to correctly interpret a successful preflight result as 0. A review comment identifies a potential build issue where the Testing framework is used without ensuring the Package.swift tools version or dependencies support it.
hewigovens
force-pushed
the
codex/fix-app-management-permission-loop
branch
from
May 17, 2026 06:22
c90c329 to
1cd3885
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
From #10.
This corrects the App Management permission preflight check so GhostTile treats
TCCAccessPreflightresult0as granted. The previous logic interpreted the result backwards, which could keep showing the App Management alert even after the user had granted permission.This also bumps the app release metadata to
2.0.7 (24)and adds thereleases/2.0.7.htmlrelease-note fragment for the patch build.Changes
AppManagementPermissionStatusReaderto map preflight result0to allowed.GhostTileAppTestscoverage for the preflight result mapping.2.0.6 (23)to2.0.7 (24).2.0.7.Impact
Users who already granted App Management permission should no longer get stuck in the repeated authorization prompt loop. The app still falls back to the existing guidance flow when permission is missing or cannot be read.
Validation
just formatjust lint(passes with existing unrelated warnings)swift testjust buildcodesign --verify --deep --strict --verbose=2 GhostTile.app