chore: migrate to pnpm, oxlint/oxfmt and release-please - #55
Merged
Merged
Conversation
Replace npm with pnpm (pnpm-lock.yaml, packageManager field) and biome with oxlint + oxfmt, matching the toolchain used across Hexlet repositories. oxlint enables all 12 plugins explicitly: by default it only loads typescript, unicorn and oxc, so import, promise, node, jsdoc, vitest, react, react-perf, jsx-a11y and vue checks would silently not run. The Makefile spells the quiet flag as `pnpm --silent run <name>`. npm treated a trailing -s as --silent, pnpm forwards it to the command instead. It matters for the docs target in particular, where output is redirected into a file and the pnpm banner would land inside it. .oxfmtignore keeps oxfmt off non-JS files, which it would otherwise rewrite. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
release-please tracks the version and CHANGELOG from conventional commits and publishes in the same workflow, gated on release_created. Publishing does not live in a tag-triggered workflow: release-please pushes the tag with GITHUB_TOKEN, and GitHub does not run workflows for events it raises, so such a workflow never fires. release.yml is removed rather than left looking like it publishes. Node CI now runs on pull requests only. It used to run again on the merge commit, re-testing what the pull request had already tested, so a merge started two workflows on one commit. PR titles are linted because squash merges turn them into the commit message release-please reads. dependabot sets commit-message.prefix: chore so its PRs pass that lint and do not trigger a version bump. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Pure formatting, no behaviour change. The diff is quote style: biome was configured with single quotes, oxfmt defaults to double ones, and the default is the convention. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the repository in line with the Hexlet-wide toolchain, same recipe as hexlet-components/js-pairs#57.
typescript,unicornandoxcload).release.ymlis removed: release-please pushes the tag withGITHUB_TOKEN, and GitHub does not run workflows for events it raises, so that workflow never fired.Commits are split so the diff stays readable: tooling, CI and the pure-formatting pass are separate.