fix(cli): persist authoring skill in hyperframes.json for durable render attribution#2762
Open
WaterrrForever wants to merge 1 commit into
Open
fix(cli): persist authoring skill in hyperframes.json for durable render attribution#2762WaterrrForever wants to merge 1 commit into
WaterrrForever wants to merge 1 commit into
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
…der attribution authoring_skill was stamped only on the first render through a workflow passing --skill, so re-renders, `npm run render`, --batch, existing-project renders, and general-video lost it — leaving 77-96% of real-human render volume un-attributed and the skills-penetration metric misleadingly low. Persist the owning skill in hyperframes.json: `init --skill` stamps it at creation, `render` resolves the flag then falls back to the stored value, and an explicit --skill seeds it (seed-once, never overwriting the creating workflow's identity). Activate all render-producing creation workflows to declare their skill at init. Forward-only: does not rewrite historical telemetry.
WaterrrForever
force-pushed
the
fix/skill-attribution-persistence
branch
from
July 24, 2026 12:58
b4dfc06 to
dc4edc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Skills penetration" tile on the growth dashboard looked like it dropped week-over-week. It's not a skills regression —
authoring_skilltelemetry is structurally incomplete. Today it's stamped only on the first render that goes through a workflow passing--skill, so re-renders,npm run render,--batch, existing-project renders, andgeneral-videolose it or never had it. Across recent weeks 77–96% of every week's real-human render volume carries no attribution, which pins the (render-weighted) metric in the single digits and makes it swing on batch/re-render volume.This makes attribution durable: the owning skill is persisted once in the project's
hyperframes.json, and every later render inherits it without re-passing--skill.Root cause
authoring_skill(packages/cli/src/telemetry/events.ts) is derived solely from the--skillflag increateRenderPlan(packages/cli/src/commands/render/plan.ts). Nothing persisted it, so attribution was lost on the highest-volume paths:npm run renderwrapper (packages/cli/src/commands/init.ts), and--batchnever re-pass the flag;hyperframes-cli(skills/hyperframes/SKILL.md), whose render examples omit--skill;general-videonever passed--skillat all.Verified against PostHog (project 356858): high-volume installs are overwhelmingly 0%-attributed, and the 07-12 → 07-19 "drop" is a partial current week plus a ~4× surge in distinct rendering installs (a broad long tail, not a few whales) — not a regression.
Fix
Persist the owning skill in
hyperframes.json(ProjectConfig.authoringSkill):hyperframes init --skill=<slug>stamps it into the project config at creation.hyperframes renderresolves the explicit--skillflag → else the persisted value, so flag-less re-renders /--batch/npm run renderstay attributed to the workflow that created the project.--skillon render seeds the stamp — seed-once: it never overwrites an existing owner (a one-off--skillstill governs that render's telemetry but does not rewrite the project's identity).initcall.Test plan / Validation
packages/cli/src/utils/projectConfig.test.ts— +6 tests (slug-gate on read, seed-once, create-if-missing, preserves other config fields)packages/cli/src/commands/render/plan.test.ts— +2 tests (flag-less render inherits the persisted stamp; explicit--skilloverrides it)oxlintandoxfmtclean on all changed files;tsc --noEmitclean on all changed filesdocs/schema/hyperframes.jsonupdated (schema isadditionalProperties:false, so the new field is required there)Scope / limitations
slideshowis intentionally out of scope: it outputs apresentdeck /snapshotstills, never an MP4, so it emits norender_complete. Domain skills (hyperframes-core, media-use, …) are correctly not counted — they are building blocks, not authoring workflows.