fix(fonts): parse font family values safely#2778
Open
jrusso1020 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:rootcustom properties; scoped, dynamic, cyclic, inline, or same-name malformed declarations remain unresolvedvar()fallback candidates without manufacturingMontserrat Bold")orserif)namesWhy
Fresh production failures include raw comma-split artifacts, CSS-wide values such as
inherit, and valid fallback families hidden insidevar(). The previous producer and lint implementations interpreted these values differently. This PR makes those surfaces agree while preserving existing browser-cascade behavior for unresolved variables.This is stacked on #2768, which contains the observed deterministic alias containment. It does not enable new render routing or add a new default plan rejection.
Correctness and rollout
"ACME(Display)"and"var(--Display)"stay real family names"inherit","serif", and"system-ui"are literal families; only unquoted forms are CSS-wide/generic valuesvar()/env()remain unresolved and are not fetched or newly rejected by plan validationValidation