Repository navigation
New Pass.Action.placeIdentifier property. - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An addition has been made to the
Pass.Actiontype. This PR adds an optionalplaceIdentifierproperty toPass.Actionfor.placefeatured actions.Although featured actions generally use
urlfor their destination,.placerequires a separateplaceIdentifiercontaining an Apple Maps Place ID (likeI63802885C8189B2B). Providing a Maps URL inurldoes not satisfy that requirement.This field is missing from Apple’s public featured-actions documentation. Direct testing against macOS 27 PassKitCore confirmed that the parser rejects
.placeactions containing only a URL and accepts those containingplaceIdentifier.The new parameter defaults to
nil, preserving existing initializer calls.