Skip to content

Catch invalid address lookup responses in waze_travel_time - #183703

Merged
erwindouna merged 1 commit into
home-assistant:devfrom
eifinger:waze_travel_time_catch_invalid_address_lookup_responses
Sep 30, 2026
Merged

erwindouna merged 1 commit into
home-assistant:devfrom
eifinger:waze_travel_time_catch_invalid_address_lookup_responses

Conversation

@eifinger

Copy link
Copy Markdown
Contributor

Breaking change

Proposed change

Bumps pywaze to include the fix that catches invalid HTTP responses for address lookups.
eifinger/pywaze@v1.2.0...v1.2.1
eifinger/pywaze#105

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI balanced review requested due to automatic review settings September 30, 2026 08:45
@home-assistant home-assistant Bot added bugfix cla-signed integration: waze_travel_time small-pr PRs with less than 30 lines. Top 200 Integration is ranked within the top 200 by usage by-code-owner Quality Scale: No score labels Sep 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The valid upstream release is consistently pinned and integrates with existing error handling.

Review effort: Balanced
Findings: None

What changed in this PR

Bumps pywaze to gracefully handle invalid address lookup responses as WRCError.

Changes:

  • Updates pywaze from 1.2.0 to 1.2.1.
  • Synchronizes the generated requirements file.
File Description
homeassistant/​components/​waze_travel_time/​manifest.json Updates the integration dependency.
requirements_all.txt Synchronizes the global dependency pin.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@erwindouna erwindouna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eifinger!

@github-actions

Copy link
Copy Markdown

Check requirements

Checked at commit e155513.

⚠️ Some checks require attention — see the details below.

Package Old New No Advisories Not Yanked Repo Public CI Upload Release Pipeline Security PR Link Async Safe
pywaze 1.2.0 1.2.1 ✅ ✅ ❌ ⚠️ — ❌ ❌ ❌
📦 pywaze: 1.2.0 → 1.2.1
  • No Advisories: ✅ No active advisories reported by PyPI for version 1.2.1.
  • Not Yanked: ✅ Version 1.2.1 is a live (non-yanked) release.
  • Repo Public: ❌ PyPI does not advertise a source repository URL.
  • CI Upload: ⚠️ No PEP 740 provenance attestation present on PyPI. Upload method cannot be verified from PyPI alone.
  • Release Pipeline: — Skipped because the source repository is not publicly accessible.
  • Security: ❌ No source repository URL on PyPI — source cannot be inspected.
  • PR Link: ❌ PyPI does not advertise a source repository URL.
  • Async Safe: ❌ PyPI does not advertise a source repository URL.

Generated by Check requirements (AW) · copilot · auto · 20 AIC · ⌖ 7.88 AIC · ⊞ 13.3K · ◷

@erwindouna

Copy link
Copy Markdown
Member

Check requirements

Checked at commit e155513.

⚠️ Some checks require attention — see the details below.

Package Old New No Advisories Not Yanked Repo Public CI Upload Release Pipeline Security PR Link Async Safe
pywaze 1.2.0 1.2.1 ✅ ✅ ❌ ⚠️ — ❌ ❌ ❌
📦 pywaze: 1.2.0 → 1.2.1

  • No Advisories: ✅ No active advisories reported by PyPI for version 1.2.1.
  • Not Yanked: ✅ Version 1.2.1 is a live (non-yanked) release.
  • Repo Public: ❌ PyPI does not advertise a source repository URL.
  • CI Upload: ⚠️ No PEP 740 provenance attestation present on PyPI. Upload method cannot be verified from PyPI alone.
  • Release Pipeline: — Skipped because the source repository is not publicly accessible.
  • Security: ❌ No source repository URL on PyPI — source cannot be inspected.
  • PR Link: ❌ PyPI does not advertise a source repository URL.
  • Async Safe: ❌ PyPI does not advertise a source repository URL.

Generated by Check requirements (AW) · copilot · auto · 20 AIC · ⌖ 7.88 AIC · ⊞ 13.3K · ◷

@eifinger you think you can this, for a later iteration?

@erwindouna

Copy link
Copy Markdown
Member

Test failure unrelated.

@erwindouna
erwindouna merged commit 81e11bb into home-assistant:dev Sep 30, 2026
50 of 51 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Waze no longer working with address, only coordinates

3 participants