Conversation
bgoncal
changed the title
Contributor
|
Found 5 unused localization strings in the codebase. Click to see detailsTo remove them, run the |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds two-way audio (“talkback”) support to the in-app WebRTC camera player by introducing a microphone toggle (when supported by the camera entity) and renegotiating the WebRTC session using camera/webrtc/re_offer.
Changes:
- Adds localized strings and SwiftGen accessors for talkback UI labels and microphone-permission messaging.
- Extends the WebRTC player/view model to detect talkback support, request microphone permission, and trigger WebRTC re-offer renegotiation.
- Updates
WebRTCClientto support an optional local microphone track and to preserve mute state when remote audio tracks change.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/Shared/Resources/Swiftgen/Strings.swift | Adds SwiftGen accessors for new talkback localization keys. |
| Sources/App/Resources/en.lproj/Localizable.strings | Adds English strings for talkback labels and microphone-denied messaging. |
| Sources/App/Cameras/CameraPlayer/WebRTC/WebRTCViewPlayerViewModel.swift | Implements talkback state, mic permission request, and re-offer signaling handling. |
| Sources/App/Cameras/CameraPlayer/WebRTC/WebRTCVideoPlayerView.swift | Adds mic toggle to the player toolbar (shown only when talkback is supported). |
| Sources/App/Cameras/CameraPlayer/WebRTC/WebRTCClient.swift | Adds optional microphone-track support and separates playback vs recording peer-connection factories. |
bgoncal
marked this pull request as draft
July 8, 2026 21:34
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4994 +/- ##
=======================================
Coverage ? 52.01%
=======================================
Files ? 299
Lines ? 19656
Branches ? 0
=======================================
Hits ? 10225
Misses ? 9431
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 10, 2026
bgoncal
added a commit
that referenced
this pull request
Jul 17, 2026
## Summary Camera player UI improvements, independent of two-way audio: - Extracts the WebRTC player controls into a dedicated `WebRTCVideoPlayerControlsView`. - Adds `WebRTCVideoPlayerViewControllerWrapper` (a `UIViewControllerRepresentable` that drives the player view controller from SwiftUI via an `isVideoPlaying` binding). - Reworks the `WebRTCVideoPlayerView` and `CameraPlayerView` layout. The talkback control is present but stays hidden (gated on `isTalkbackSupported`, which is `false` on `main`), so this PR is purely UI and adds no two-way-audio behavior. Base for the stacked two-way-audio PR #4994. ## Screenshots ## Link to pull request in Documentation repository Documentation: home-assistant/companion.home-assistant# ## Any other notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two-way audio to the in-app WebRTC camera player. A mic toggle appears in the player when the camera reports the
TWO_WAY_AUDIOfeature, enabling it adds a local microphone track.Depends on backend support from home-assistant/core#148282.
Screenshots
ha.mp4
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes