refactor!: client GraphQL protocol version 2 → 1 - #164
Merged
Conversation
Never-released wire family; first public ship should be protocol v1, not v2. Constants, envelopes, compiler emit, client checks, fixtures, and docs only. Left unrelated versions alone (variableCodec v2, digest domain tags, package semver).
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
All-features and distributed_cli integration asserted stale schema fingerprints that include protocol_version in the hash input.
Normalize client manifest, variableCodec, command extension slots, and protocol-manifest epoch to 1 so the first public release does not imply prior public wire families. Refresh fingerprints, goldens, and fixtures.
Ignored distributed_cli integration test expected the pre-v1 schema fingerprint; regenerate to match manifest/epoch/slot version renames.
all-features client_surface_parity asserted a pre-v1 schema hash for the orders postgres role surface after wire version renames.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DistributedEnvelopeV2→DistributedEnvelopeV1, compiler/artifact emit, JS client checks/types, fixtures, and docs.variableCodec.version(still 2), digest domain*.v1tags, package/crate semver, OAuth paths, test payload strings liketodos-v1.Constants
DISTRIBUTED_CLIENT_PROTOCOL_VERSION = 1DISTRIBUTED_PROTOCOL_VERSION = 1PROTOCOL_VERSION = 1Verification
cargo test --features graphql,sqlite --lib graphql::(186 passed)cargo test -p distributed_cli(full package green)cargo test --features graphql,sqlite --test graphql_query_protocol(17 passed)cd js && npm run quality(253 tests + pack:smoke + publint)Base
Stacked on
tasks--graphql-qs-epic(#127).