fix(core): handle tool execution errors with isError flag and add tests - #70
Open
fabiooliveir wants to merge 1 commit into
Open
fabiooliveir wants to merge 1 commit into
fabiooliveir wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two key improvements for the Hostinger MCP Server:
MCP Specification Compliance (
isError: true):CallToolResultwithisError: trueand the error details in the text content, allowing LLM clients (Claude, Cursor, Gemini, Copilot) to understand and self-correct on API failures.Tool not found) are preserved.Automated Test Suite & Hygiene:
test/runtime-errors.test.jsusing Node.js native test runner (npm test) covering success (2xx), API errors (400, 401, 422, 5xx), connection drops (ECONNREFUSED), and custom tool validations..gitignoreto prevent committingdist/,node_modules/, and sensitive.envcredentials.Verification
npm test: 8/8 tests passing.npm run build: TypeScript compilation succeeded without errors.