Repository navigation
Improve debugger assemble/disassemble compatiblity - #21892
Merged
Merged
Conversation
Update armips for VFPU instruction parsing changes: - Kingcom/armips#255 - Kingcom/armips#256 Remove brackets from VFPU instruction `vpfx*` params Rename VFPU instruction `vuc2i.s` to `vuc2ifs.s` Add brackets to VFPU instruction `vpfxd` saturation operations (i.e. [0:1] & [-1:1]) Rename FPU instructions `c.$OP` to `c.$OP.s` Fix VFPU instruction `vuc2ifs.s` `vd` size in disassembly Replace `CC[imm3]` with `imm3` in VFPU instructions `vcmov*` & `bv*` disassembly
Owner
|
Seems good. Since there are likely not that many users of this functionality currently, I won't worry too much about breaking existing use cases and if so they are easily fixed. |
hrydgard
approved these changes
Jul 8, 2026
hrydgard
enabled auto-merge
July 8, 2026 08:22
Collaborator
|
Does this fix the vhtfm4.q issue? |
Collaborator
|
|
Contributor
Author
|
Fix for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I identified & tested these changes via a websocket API script that disassembled each instruction in a game's
.text, assembled the output, disassembled again & checked for differences.Update armips for VFPU instruction parsing changes:
Remove brackets from VFPU instruction
vpfx*param disassemblyRename VFPU instruction
vuc2i.stovuc2ifs.sAdd brackets to VFPU instruction
vpfxdsaturation operations (i.e. [0:1] & [-1:1])Rename FPU instructions
c.$OPtoc.$OP.sFix VFPU instruction
vuc2ifs.svdsize in disassemblyReplace
CC[imm3]withimm3in VFPU instructionsvcmov*&bv*disassembly