Repository navigation
Readback: Only scale a framebuffer down when it's rendered bigger than maxScaleFactor - #22473
Merged
Merged
Conversation
…caleFactor ReadFramebufferForDebug scaled the buffer down, cropped to its drawn size, whenever the render width was more than the drawn width times maxScaleFactor. At 1x that's any buffer wider than what has been drawn in it, though nothing needs scaling. Headless compares at maxScaleFactor 1, so this cut off most of the screen in Gangs of London, which draws a 256 px wide region: its dumps went from 78 to 62,017 pixels differing from the PSP. Now it only scales down when the render scale is above maxScaleFactor, and then scales the whole buffer, since a display at an offset can sit past the drawn width. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hrydgard
changed the title
hrydgard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude says
ReadFramebufferForDebug scaled the buffer down, cropped to its drawn size, whenever the render width was more than the drawn width times maxScaleFactor. At 1x that's any buffer wider than what has been drawn in it, though nothing needs scaling.
Headless compares at maxScaleFactor 1, so this cut off most of the screen in Gangs of London, which draws a 256 px wide region.
Now it only scales down when the render scale is above maxScaleFactor, and then scales the whole buffer, since a display at an offset can sit past the drawn width.