Repository navigation
Add eMudhra interception option - #290
Open
igolaizola wants to merge 1 commit into
Open
igolaizola wants to merge 1 commit into
igolaizola wants to merge 1 commit into
Conversation
Enable an extra HTTPS port through the Mockttp session API and show manual setup instructions. Refs httptoolkit/httptoolkit#934
There was a problem hiding this comment.
🟡 Changes recommended
The pinned Mockttp dependency lacks the required APIs, causing type-checking failures and potential activation crashes, while the setup panel can display stale network addresses.
2 open issues
What changed in this PR
Adds an experimental eMudhra interception option that requests a separate HTTPS port through the Mockttp session API and provides manual client setup instructions, while leaving the normal proxy’s local CA unchanged.
Changes:
- Exposes eMudhra interception when advertised by the server.
- Adds port activation, connection addresses, and retryable error handling.
- Adds component tests for activation, instructions, and retries.
| File | Description |
|---|---|
test/unit/components/intercept/emudhra-config.spec.tsx |
Tests displayed addresses, activation callbacks, and error recovery. |
src/model/proxy-store.ts |
Reads extra-HTTPS capabilities and adds port activation. |
src/model/interception/interceptors.ts |
Registers the capability-gated eMudhra option. |
src/model/interception/interceptor-store.ts |
Passes extra-HTTPS capabilities into option selection. |
src/components/intercept/config/emudhra-config.tsx |
Adds activation UI and manual setup instructions. |
Review effort: Balanced
| extraHttpsNames: string[] = []; | ||
|
|
||
| enableExtraHttps(name: string): Promise<number> { | ||
| return this.adminClient.sendQuery(this.mockttpRequestBuilder.buildEnableExtraHttpsQuery(name)); |
| @observable error: string | undefined; | ||
|
|
||
| componentDidMount() { | ||
| this.enable(); |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable an extra HTTPS port through the Mockttp session API and show manual setup instructions.
Refs httptoolkit/httptoolkit#934