Skip to content

Check Node maintenance setup across a repository fleet - #22

Merged
omry merged 1 commit into
mainfrom
pr22
Oct 18, 2026
Merged

omry merged 1 commit into
mainfrom
pr22

Conversation

@omry

@omry omry commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Add a manual and reusable fleet workflow with an inventory beside shared defaults. Read each listed default branch as immutable data, verify configuration, toolchain declarations, caller pins and schedules, and maintain one central setup issue per inventory. Reuse that issue across failures, closure and recurrence.

Keep optional private-repository read credentials in the scanner job and host issue writes in a separate reporter. Reuse existing configuration, static project validation and bot-owned issue lifecycle helpers. The checker does not install dependencies, execute project code, audit dependencies, or change consumers.

Document both workflows, inventories, local overrides, optional scheduling and static-check limits. Include Hydra and OmegaConf in the example inventory.

Validation: 1,073 public tests; Ruff lint/format; runtime type checks; 54 local links and anchors; 19 parsed JSON/YAML examples; four modeled npm/pnpm configurations; read-only live setup checks passed for Hydra and OmegaConf. Hosted fleet execution remains a post-merge check.


@omry
omry marked this pull request as ready for review October 18, 2026 17:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T17:46:09.783923Z e3c4a6c Manual request
🔒 Security Review ✅ Completed 2026-10-18T17:29:22.642195Z 859fef2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@omry

omry commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor Author

PR-cycle state — maintained automatically. Do not edit by hand.

Mechanical PR-cycle state (JSON)
{
  "approval": {
    "candidate_revision_fingerprint": "sha256:b4ca0f8d567e8507d1f9abc64ad003e6f628a357822e3e677a7b55f7f2cc52f0",
    "evidence": {
      "attestations": [],
      "candidate_revision_fingerprint": "sha256:b4ca0f8d567e8507d1f9abc64ad003e6f628a357822e3e677a7b55f7f2cc52f0",
      "check_conclusions": [
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 117743240635
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 117743240508
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 117743240707
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 117743240580
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 117743240568
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 117743240461
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 117743240541
        }
      ],
      "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
      "finding_dispositions_digest": "sha256:7174dcfd80aa96574a8f1e709744559dc9b00237302a84d479dae50b908dd271",
      "operation_identity": "sha256:92aaec7dbd84d721f26f600b5a0f4b2b435b8aaa5ca05217ee9d1034d9c71766",
      "review_request": {
        "body_digest": "sha256:9ce773c75fd11ef43e3497d87c8bcfd35b811a9891544b47f1b033c18725904e",
        "id": 6253064387
      },
      "review_result": {
        "body_digest": "sha256:bc3b727ad70ea50b68aabf6ed38a37e9db8c992d97a2cf5c9d3c32e7485d2e77",
        "id": 6253099916
      }
    },
    "evidence_fingerprint": "sha256:7975289aed14605e2933b8c1509b48eee6c8dd2b53360c0b453510d72928e291",
    "head_sha": "e3c4a6cdccffa1370e9ed95545a91f27f97d41ee",
    "operation_identity": "sha256:92aaec7dbd84d721f26f600b5a0f4b2b435b8aaa5ca05217ee9d1034d9c71766",
    "review_request_id": 6253064387,
    "review_result_id": 6253099916,
    "status": "approved-evidence-recorded"
  },
  "candidate_revision_fingerprint": "sha256:b4ca0f8d567e8507d1f9abc64ad003e6f628a357822e3e677a7b55f7f2cc52f0",
  "check_conclusions": [
    {
      "conclusion": "SUCCESS",
      "name": "test",
      "run_id": 117743240635
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, npm, 11.9.0)",
      "run_id": 117743240508
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.20.0)",
      "run_id": 117743240707
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (22, pnpm, 11.21.0)",
      "run_id": 117743240580
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, npm, 11.9.0)",
      "run_id": 117743240568
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.20.0)",
      "run_id": 117743240461
    },
    {
      "conclusion": "SUCCESS",
      "name": "toolchain (24, pnpm, 11.21.0)",
      "run_id": 117743240541
    }
  ],
  "check_observations": [
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 117743240635,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39150587574/job/117743240635"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 117743240508,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39150587574/job/117743240508"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 117743240707,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39150587574/job/117743240707"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 117743240580,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39150587574/job/117743240580"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 117743240568,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39150587574/job/117743240568"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 117743240461,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39150587574/job/117743240461"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 117743240541,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39150587574/job/117743240541"
        }
      ],
      "head_sha": "e3c4a6cdccffa1370e9ed95545a91f27f97d41ee",
      "id": "sha256:22777e666d2d94a34dca32c1b0fe240a38f736368276dba4e289583d306c59fc",
      "required_checks": [
        "test",
        "toolchain (22, npm, 11.9.0)",
        "toolchain (22, pnpm, 11.20.0)",
        "toolchain (22, pnpm, 11.21.0)",
        "toolchain (24, npm, 11.9.0)",
        "toolchain (24, pnpm, 11.20.0)",
        "toolchain (24, pnpm, 11.21.0)"
      ],
      "status": "success"
    },
    {
      "checks": [
        {
          "conclusion": "SUCCESS",
          "name": "test",
          "run_id": 117739513532,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39149314028/job/117739513532"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, npm, 11.9.0)",
          "run_id": 117739513690,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39149314028/job/117739513690"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.20.0)",
          "run_id": 117739513695,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39149314028/job/117739513695"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (22, pnpm, 11.21.0)",
          "run_id": 117739513717,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39149314028/job/117739513717"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, npm, 11.9.0)",
          "run_id": 117739513713,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39149314028/job/117739513713"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.20.0)",
          "run_id": 117739513656,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39149314028/job/117739513656"
        },
        {
          "conclusion": "SUCCESS",
          "name": "toolchain (24, pnpm, 11.21.0)",
          "run_id": 117739513746,
          "run_status": "completed",
          "status": "success",
          "url": "https://github.com/hydra-ecosystem/github-actions/actions/runs/39149314028/job/117739513746"
        }
      ],
      "head_sha": "859fef22e12e7566868edd789f699ca3c0ca2fc0",
      "id": "sha256:e38c3f6033a0b8fa9f5d296211069701b349a77c7d9513076c8063472aeceeb9",
      "required_checks": [
        "test",
        "toolchain (22, npm, 11.9.0)",
        "toolchain (22, pnpm, 11.20.0)",
        "toolchain (22, pnpm, 11.21.0)",
        "toolchain (24, npm, 11.9.0)",
        "toolchain (24, pnpm, 11.20.0)",
        "toolchain (24, pnpm, 11.21.0)"
      ],
      "status": "success"
    }
  ],
  "delivery_deferral_ledger_digest": "sha256:4f53cda18c2baa0c0354bb5f9a3ecbe5ed12ab4d8e11ba873c2f11161202b945",
  "delivery_deferrals": [],
  "findings": [
    {
      "disposition": "current-slice",
      "evidence": [
        "https://github.com/hydra-ecosystem/github-actions/pull/22#discussion_r4307980611",
        "https://github.com/hydra-ecosystem/github-actions/pull/22#discussion_r4308016509",
        "https://github.com/hydra-ecosystem/github-actions/commit/e3c4a6cdccffa1370e9ed95545a91f27f97d41ee"
      ],
      "id": "codex-4307980611",
      "invariant": "Supported caller jobs must not be blocked by unrelated prerequisite jobs",
      "proposed_paths": [
        "node/runtime/fleet.py",
        "node/tests/test_fleet_setup.py",
        "docs/node-fleet-setup.md"
      ],
      "rationale": "Reproduced offline as a false healthy fleet verdict; bounded correction restores setup verification.",
      "resolution_evidence": [
        "Truth fix implemented and verified with targeted regression tests;52 fleet tests and1078 total tests passed; static/docs checks passed; addressed review thread replied and resolved."
      ],
      "status": "resolved",
      "thread_id": "PRRT_kwDOVJzQB86tsuC5"
    },
    {
      "disposition": "current-slice",
      "evidence": [
        "https://github.com/hydra-ecosystem/github-actions/pull/22#discussion_r4307980623",
        "https://github.com/hydra-ecosystem/github-actions/pull/22#discussion_r4308016617",
        "https://github.com/hydra-ecosystem/github-actions/commit/e3c4a6cdccffa1370e9ed95545a91f27f97d41ee"
      ],
      "id": "codex-4307980623",
      "invariant": "Supported GitHub cron weekdays are0-6 orSUN-SAT",
      "proposed_paths": [
        "node/runtime/fleet.py",
        "node/tests/test_fleet_setup.py",
        "docs/node-fleet-setup.md"
      ],
      "rationale": "Reproduced offline as a false healthy fleet verdict; bounded correction restores setup verification.",
      "resolution_evidence": [
        "Truth fix implemented and verified with targeted regression tests;52 fleet tests and1078 total tests passed; static/docs checks passed; addressed review thread replied and resolved."
      ],
      "status": "resolved",
      "thread_id": "PRRT_kwDOVJzQB86tsuC_"
    }
  ],
  "pr": {
    "base_ref": "main",
    "base_sha": "461514cbc556450709b419ce01be89658ab8c2fe",
    "body_digest": "sha256:93977ca81f1dab3ca3ff846f7486f54884d95d22edb7c9375fa64c03f36f2816",
    "diff_digest": "sha256:0fc9fa5f7ff229ac39320a3dc90f2d22ed4f2222ab195b2afb830482d0cd8528",
    "head_ref": "pr22",
    "head_sha": "e3c4a6cdccffa1370e9ed95545a91f27f97d41ee",
    "pr": 22,
    "repository": "hydra-ecosystem/github-actions",
    "scope_authority": [],
    "title_digest": "sha256:49b923c1e13fc710fbb23958ce1645d68915859d55f9c6c9052c683a61faf090"
  },
  "record_version": 6,
  "review_observations": [],
  "review_requests": [
    {
      "base_established_at": "2026-10-18T17:22:48Z",
      "base_ref": "main",
      "base_sha": "461514cbc556450709b419ce01be89658ab8c2fe",
      "body_digest": "sha256:84decb6ffa74de19d743065d1da68660c1a80f3e6ac1c8dda9d667831d21f07d",
      "created_at": "2026-10-18T17:26:13Z",
      "head_sha": "859fef22e12e7566868edd789f699ca3c0ca2fc0",
      "id": 6252893584,
      "kind": "regular-review"
    },
    {
      "base_established_at": "2026-10-18T17:22:48Z",
      "base_ref": "main",
      "base_sha": "461514cbc556450709b419ce01be89658ab8c2fe",
      "body_digest": "sha256:9ce773c75fd11ef43e3497d87c8bcfd35b811a9891544b47f1b033c18725904e",
      "created_at": "2026-10-18T17:42:49Z",
      "head_sha": "e3c4a6cdccffa1370e9ed95545a91f27f97d41ee",
      "id": 6253064387,
      "kind": "regular-review"
    }
  ],
  "review_results": [
    {
      "base_ref": "main",
      "base_sha": "461514cbc556450709b419ce01be89658ab8c2fe",
      "body_digest": "sha256:23134384641fc6c58298a856de6eae9b250686200c882ef973fd554d0915bc66",
      "commit_id": "859fef22e12e7566868edd789f699ca3c0ca2fc0",
      "id": 5564065538,
      "inline_message_ids": [
        4307980611,
        4307980623
      ],
      "request_comment_id": 6252893584,
      "result_kind": "findings",
      "status": "result",
      "submitted_at": "2026-10-18T17:30:05Z",
      "unresolved_thread_ids": [
        "PRRT_kwDOVJzQB86tsuC5",
        "PRRT_kwDOVJzQB86tsuC_"
      ]
    },
    {
      "base_ref": "main",
      "base_sha": "461514cbc556450709b419ce01be89658ab8c2fe",
      "body_digest": "sha256:bc3b727ad70ea50b68aabf6ed38a37e9db8c992d97a2cf5c9d3c32e7485d2e77",
      "commit_id": "e3c4a6cdccffa1370e9ed95545a91f27f97d41ee",
      "id": 6253099916,
      "inline_message_ids": [],
      "request_comment_id": 6253064387,
      "result_kind": "clean",
      "status": "result",
      "submitted_at": "2026-10-18T17:46:08Z",
      "unresolved_thread_ids": []
    }
  ],
  "revision_fingerprint": "sha256:b4ca0f8d567e8507d1f9abc64ad003e6f628a357822e3e677a7b55f7f2cc52f0",
  "rounds": [
    {
      "applied_fix_paths": [
        "docs/node-fleet-setup.md",
        "node/runtime/fleet.py",
        "node/tests/test_fleet_setup.py"
      ],
      "disposition_changes": [
        "codex-4307980611",
        "codex-4307980623"
      ],
      "effective_diff_digest": "sha256:0fc9fa5f7ff229ac39320a3dc90f2d22ed4f2222ab195b2afb830482d0cd8528",
      "finding_ids": [
        "codex-4307980611",
        "codex-4307980623"
      ],
      "invariants": [
        "Supported caller jobs must not be blocked by unrelated prerequisite jobs",
        "Supported GitHub cron weekdays are0-6 orSUN-SAT"
      ],
      "outcome": "corrected-head-needs-review",
      "proposed_fix_paths": [
        "docs/node-fleet-setup.md",
        "node/runtime/fleet.py",
        "node/tests/test_fleet_setup.py"
      ],
      "resulting_head": "e3c4a6cdccffa1370e9ed95545a91f27f97d41ee",
      "review_observation_id": null,
      "review_request_id": 6252893584,
      "review_result_id": 5564065538,
      "reviewed_head": "859fef22e12e7566868edd789f699ca3c0ca2fc0",
      "root_cause": "Static caller checks allowed unrelated job prerequisites; cron bounds inherited the generic Sunday7 alias outside GitHub range.",
      "round": 1,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    },
    {
      "applied_fix_paths": [],
      "disposition_changes": [],
      "effective_diff_digest": "sha256:0fc9fa5f7ff229ac39320a3dc90f2d22ed4f2222ab195b2afb830482d0cd8528",
      "finding_ids": [],
      "invariants": [
        "Supported setup checks and issue lifecycle satisfy the requested static scope"
      ],
      "outcome": "clean",
      "proposed_fix_paths": [],
      "resulting_head": "e3c4a6cdccffa1370e9ed95545a91f27f97d41ee",
      "review_observation_id": null,
      "review_request_id": 6253064387,
      "review_result_id": 6253099916,
      "reviewed_head": "e3c4a6cdccffa1370e9ed95545a91f27f97d41ee",
      "root_cause": null,
      "round": 2,
      "unresolved_current_slice_findings": 0,
      "unresolved_design_blockers": 0
    }
  ],
  "schema": "awd:swe:pr-cycle-state",
  "version": 2
}

@omry

omry commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

@codex, regular review 859fef2

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 859fef22e1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread node/runtime/fleet.py Outdated
Comment thread node/runtime/fleet.py Outdated
Add a manual and reusable fleet workflow with an inventory beside shared defaults. Read each listed default branch as immutable data, verify configuration, toolchain declarations, caller pins and schedules, and maintain one central setup issue per inventory. Reuse that issue across failures, closure and recurrence.

Keep optional private-repository read credentials in the scanner job and host issue writes in a separate reporter. Reuse existing configuration, static project validation and bot-owned issue lifecycle helpers. The checker does not install dependencies, execute project code, audit dependencies, or change consumers.

Document both workflows, inventories, local overrides, optional scheduling and static-check limits. Include Hydra and OmegaConf in the example inventory.

Validation: 1,073 public tests; Ruff lint/format; runtime type checks; 54 local links and anchors; 19 parsed JSON/YAML examples; four modeled npm/pnpm configurations; read-only live setup checks passed for Hydra and OmegaConf. Hosted fleet execution remains a post-merge check.
@omry

omry commented Oct 18, 2026

Copy link
Copy Markdown
Contributor Author

@codex, regular review e3c4a6c

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: e3c4a6cdcc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@omry omry added the approved label Oct 18, 2026
@omry
omry added this pull request to stack #24 October 18, 2026 18:16
@omry
omry merged commit 9bbd736 into main Oct 18, 2026
14 checks passed
@omry
omry deleted the pr22 branch October 18, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant