Skip to content

Split large modules and functions without changing behavior #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperdrivebeep merged 2 commits into from
Oct 8, 2026
Merged

Split large modules and functions without changing behavior #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec95466
Split large modules and functions into smaller ones without changing …
Oct 8, 2026
e1b264c
Read reason codes from the modules they moved to, and rebuild the pub…
Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
296 changes: 243 additions & 53 deletions SOURCE_MANIFEST.json
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions apps/web/src/components/history/historyReasonText.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ function backendCodes(): string[] {
["application/services/research_freshness.py", /reasons=\(\s*"([A-Z_]+)"|currentness\.reasons, "([A-Z_]+)"/g],
["application/services/research_coverage.py", /reasons\.append\("([A-Z_]+)"\)/g],
["application/services/research_followup_projection.py", /reason_codes=\(\s*"([A-Z_]+)"|\("([A-Z_]+)",\)\)/g],
// The review list and comparison reasons are built in these two modules, split out of the projection.
["application/services/research_followup_calculations.py", /reason_codes=\(\s*"([A-Z_]+)"|\("([A-Z_]+)",\)\)/g],
["application/services/research_decision_delta.py", /reason_codes=\(\s*"([A-Z_]+)"|\("([A-Z_]+)",\)\)/g],
["application/services/history_projection.py", /\*currentness\.reasons, "([A-Z_]+)"/g],
];
for (const [path, pattern] of files) {
Expand Down
4 changes: 3 additions & 1 deletion apps/web/src/components/traceReasonTags.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,9 @@ function serverReasonCodes(text: string): string[] {
const found = [...text.matchAll(/f"([A-Z][A-Z_]+):\{/g), ...text.matchAll(/(?:computed=|else )\(\s*"([A-Z][A-Z_]+)",\s*\)/g)].map(match => match[1]);
return [...new Set(found)].sort();
}
const traceSource = () => readFileSync(new URL("../../../../src/thoth/application/services/verification_trace.py", import.meta.url), "utf8");
// The verdicts are computed in verification_trace_compute.py; verification_trace.py keeps the service around it.
const traceSource = () => ["verification_trace.py", "verification_trace_compute.py"]
.map(name => readFileSync(new URL("../../../../src/thoth/application/services/" + name, import.meta.url), "utf8")).join("\n");

describe("reason codes against the server", () => {
it("reads the ten codes the server gives today", () => {
Expand Down
192 changes: 7 additions & 185 deletions config/module-responsibility-budget.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,36 +140,8 @@
"policy": "schema registry only; new table families prefer owned schema modules"
},
"src/thoth/application/commands/actions_full.py": {
"baseline_lines": 978,
"baseline_lines": 830,
"top_level_symbols": [
"ProjectInput",
"ActionListInput",
"ActionReadInput",
"PortfolioListInput",
"PortfolioReadInput",
"PlanReadInput",
"StepReadInput",
"ImpactReadInput",
"AuthorizationReadInput",
"AuditReadInput",
"ActionRevisionBound",
"ReviseInput",
"PortfolioComposeInput",
"PortfolioEvaluateInput",
"RecommendInput",
"SelectInput",
"PlanComposeInput",
"PlanRevisionBound",
"PlanReviseInput",
"PlanRevalidateInput",
"StepAddInput",
"StepReviseInput",
"ImpactRecalculateInput",
"PolicyClassifyInput",
"AuthorizationPrepareInput",
"AuthorizationDecideInput",
"CompensationCreateInput",
"MergeProposeInput",
"ActionHandlers"
],
"policy": "existing Action RPC surface only; new responsibility goes to a new command/service module"
Expand Down Expand Up @@ -199,34 +171,8 @@
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
},
"src/thoth/application/commands/hypotheses_full.py": {
"baseline_lines": 981,
"baseline_lines": 822,
"top_level_symbols": [
"ProjectInput",
"HypothesisListInput",
"HypothesisReadInput",
"PortfolioListInput",
"PortfolioReadInput",
"RelationListInput",
"PredictionListInput",
"PredictionReadInput",
"AssumptionListInput",
"GenerateInput",
"CreateInput",
"RevisionBoundInput",
"ReviseInput",
"IntentUpdateInput",
"CausalUpdateInput",
"RelationAddInput",
"RelationRemoveInput",
"AssumptionAddInput",
"PredictionBindInput",
"CounterevidenceRequestInput",
"PortfolioComposeInput",
"PortfolioRevalidateInput",
"TestBindInput",
"AppraiseInput",
"SplitProposeInput",
"MergeProposeInput",
"HypothesisHandlers"
],
"policy": "existing Hypothesis RPC surface only; new responsibility goes to a new command/service module"
Expand Down Expand Up @@ -279,31 +225,8 @@
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
},
"src/thoth/application/commands/objects_full.py": {
"baseline_lines": 809,
"baseline_lines": 693,
"top_level_symbols": [
"ProjectInput",
"ObjectListInput",
"ObjectReadInput",
"CandidateListInput",
"CandidateReadInput",
"ProfileListInput",
"ProfileReadInput",
"RelationListInput",
"AttentionListInput",
"AuditReadInput",
"MaterializeInput",
"RevisionBoundInput",
"FrameReviseInput",
"ProfileApplyInput",
"FacetUpdateInput",
"RelationAddInput",
"RelationRemoveInput",
"RevalidateInput",
"WorkReplanInput",
"SplitProposeInput",
"MergeProposeInput",
"AttentionAcknowledgeInput",
"FollowupCreateInput",
"DecisionObjectHandlers"
],
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
Expand Down Expand Up @@ -380,9 +303,8 @@
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
},
"src/thoth/application/services/action_service.py": {
"baseline_lines": 957,
"baseline_lines": 854,
"top_level_symbols": [
"classify_effect_vector",
"ActionService"
],
"policy": "Action domain orchestration only; extract new policy/evaluator/compiler responsibility"
Expand Down Expand Up @@ -480,37 +402,6 @@
],
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
},
"src/thoth/application/services/research_followup_projection.py": {
"baseline_lines": 757,
"top_level_symbols": [
"project_thread_followup",
"decision_delta",
"CriterionViewReader",
"ProjectReviewReader",
"_related_records",
"_coverage_matrix",
"_matrix_row",
"_semantic_reviews",
"_matrix_summary",
"_next_action",
"_progress_state",
"_progress_items",
"_recorded_checks",
"_remaining_gaps",
"_unknowns",
"_delta_payload",
"_delta_groups",
"_change_kind",
"_reason_codes",
"_reason_refs",
"_basis_currentness",
"_object_tuple",
"_decode_cursor",
"_read_head",
"_operation_state"
],
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
},
"src/thoth/application/services/research_identity_service.py": {
"baseline_lines": 766,
"top_level_symbols": [
Expand All @@ -529,60 +420,6 @@
],
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
},
"src/thoth/application/services/user_activity_projection.py": {
"baseline_lines": 674,
"top_level_symbols": [
"source_activity_contexts",
"_record",
"_items",
"_alias",
"_safe_code",
"_redaction_classes",
"_redaction",
"_public_origin",
"_safe_section",
"_source_target",
"_relation",
"_append_stage_events",
"_append_source_events",
"_append_judgement_events",
"_append_model_events",
"_append_terminal_event",
"project_user_activity_events"
],
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
},
"src/thoth/application/services/verification_trace.py": {
"baseline_lines": 815,
"top_level_symbols": [
"TraceError",
"TraceConflict",
"_Context",
"_ids_of",
"_children",
"_requirements_of",
"_show",
"_digest",
"_select",
"_value_to_compare",
"_meets",
"_judge",
"_chain",
"_criterion_revision",
"_requirement_state",
"_requirement_revision",
"compute_verdicts",
"_rule_summary",
"_result_summary",
"_field_changes",
"dependency_changes",
"mark_stale",
"_replaced",
"HistoryPage",
"VerificationTraceService"
],
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
},
"src/thoth/application/workflows/thread_cycle.py": {
"baseline_lines": 889,
"top_level_symbols": [
Expand All @@ -594,34 +431,28 @@
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
},
"src/thoth/apps/runtime.py": {
"baseline_lines": 746,
"baseline_lines": 670,
"top_level_symbols": [
"create_runtime"
],
"policy": "composition only; new feature composition belongs in an owned module factory"
},
"src/thoth/cli.py": {
"baseline_lines": 827,
"baseline_lines": 621,
"top_level_symbols": [
"ModelProbeOutput",
"workspace_session_id",
"main",
"_interactive_shell",
"announce_workspace",
"_interactive_session",
"_module_available",
"_sandbox_adapter",
"version",
"workspace_info",
"claude_code_login",
"doctor",
"connector_sandbox_doctor",
"profile_check",
"auth_status",
"auth_connect",
"model_probe",
"source_stage",
"git_snapshot",
"run_request",
"rpc_stdio",
"events",
Expand All @@ -641,21 +472,12 @@
"CommandBus"
],
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
},
"src/thoth/protocol/notifications.py": {
"baseline_lines": 717,
"top_level_symbols": [
"notifications_for",
"notifications_for_internal_event"
],
"policy": "over the 600-line limit when it was introduced; do not grow it; lower the baseline when it is split"
}
},
"watched_long_functions": {
"src/thoth/application/services/acquisition_coordinator.py::execute_if_required": 209,
"src/thoth/application/services/critical_counter_search_coordinator.py::_execute_multi_wave": 380,
"src/thoth/application/workflows/thread_cycle.py::execute": 207,
"src/thoth/apps/runtime.py::create_runtime": 627,
"src/thoth/protocol/notifications.py::notifications_for": 255
"src/thoth/apps/runtime.py::create_runtime": 548
}
}
1 change: 1 addition & 0 deletions src/thoth/adapters/cli/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
"""CLI command adapters registered by the original thoth.cli entry point."""
Loading
Loading