Skip to content

feat(conn): support HTTP proxy basic authentication#253

Open
honzchen wants to merge 4 commits into
hyperium:masterfrom
honzchen:pr/http-proxy-basic-auth
Open

feat(conn): support HTTP proxy basic authentication#253
honzchen wants to merge 4 commits into
hyperium:masterfrom
honzchen:pr/http-proxy-basic-auth

Conversation

@honzchen

Copy link
Copy Markdown
Contributor

Fixes an issue where the client couldn’t attach basic authorization to HTTP proxy requests.

@honzchen honzchen requested a review from 0x676e67 December 29, 2025 04:59
@seanmonstar

Copy link
Copy Markdown
Member

Thanks for the PR!

We currently are able to send proxy auth without this. For instance, reqwest adds the information based on various factors. So, part of me thinks it better to not expand the legacy API.

What do you think?

@honzchen

honzchen commented Jan 5, 2026

Copy link
Copy Markdown
Contributor Author

Just to clarify my use case: I’m implementing an HTTP proxy that can chain to an upstream proxy, and the auth here is for that upstream proxy.

The tricky part is that, without touching the actual request message (like HTTPS/SOCKS proxies do), there isn’t a reliable way to automatically inject a Proxy-Authorization header for plain HTTP proxy requests. That’s why pushing this into the connector layer matters.

I agree about being cautious with the legacy API surface area, but for upstream-proxy chaining this connector-level approach is the cleanest place to handle it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants