Repository navigation
Health-warnings for stashing callback conn handles, and try to safeguard use - #258
Merged
Merged
Conversation
…t against misuse Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
peterbroadhurst
added this pull request to stack #259
October 5, 2026 21:02
EnriqueL8
reviewed
Oct 6, 2026
EnriqueL8
left a comment
EnriqueL8
left a comment
Contributor
There was a problem hiding this comment.
Thanks @peterbroadhurst , one edge case on there
Co-authored-by: Enrique Lacal <enrique.lacal@kaleido.io> Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Co-authored-by: Enrique Lacal <enrique.lacal@kaleido.io> Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Co-authored-by: Enrique Lacal <enrique.lacal@kaleido.io> Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
EnriqueL8
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #247 (v1.6.6), the
WSClientpassed toWSPostConnectHandleris bound to a single connection. Consumers that stashed it (safe before #247) end up with a handle whoseSendreturns FF00147 forever once that connection reconnects or is cycled out.This PR:
Sendon its bound handle routes via the current connection. Sends during a cycle's quiesce period still go to the old connection, and a connection that was never promoted (failedafterConnectduring a cycle) still returns FF00147.