Repository navigation
Pin the Agda proofs to Debian 13's agda 2.6.4.3 + agda-stdlib 2.1 - #3
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Conflict with
Note for the session working in 🤖 Generated with Claude Code |
The proofs were developed against Agda 2.7.0.1 and an untagged agda-stdlib 3.0 development SHA, vendored at bootstrap time. The estate standard (MetaManifold-Evidence, residual-evidence-types) is Debian's packaged toolchain inside a digest-pinned image, so this moves CompositionalDA.jl onto the same pin. Measured: the only source incompatibility between the two stdlib lines was `_≡?_` on ℤ, which 2.1 exports as `_≟_` (three sites in Prelude.agda). Every other imported name exists in 2.1; the PROOF-STATUS claim that the proofs "do not compile against v2.1" was false and is removed. * proofs/lib.sh (new): resolves the pinned Agda and stdlib or dies naming what it found; /usr/bin/agda is tried before PATH because a developer toolchain dir can shadow the Debian binary with 2.7.0.1. * proofs/check.sh (new): the whole gate in CI order — axiom audit, type-check All.agda with warnings as failures, gate self-test. * proofs/tests/gate-selftest.sh: sources lib.sh instead of requiring a bootstrap step; the three reject/ controls and seven planted defects are unchanged and still fire. * proofs/bootstrap.sh: removed with its vendoring and .agda-libraries machinery; .gitignore entries pruned. * .github/workflows/ci.yml: the proofs job now runs in debian:13-slim@sha256:d7e1… with agda-bin=2.6.4.3-1+b2 and agda-stdlib=2.1-4 from apt, then proofs/check.sh. * README.md, proofs/PROOF-STATUS.md: toolchain text updated. Verified locally: proofs/check.sh rc=0 (6 modules audited, All.agda type-checks, 3/3 rejects rejected, 7/7 audit checks fire); Pkg.test() 43/43 including the four mutants. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AjVQUkziVYywrLNsbPordh
2a5c5e4 to
4843449
Compare
…re visible (#5) Main is red after #4 (run 37036456885). This fixes both failures. - **Agda proofs:** the merge of `main` into `feat/aldex2` kept #3's step name but put the old Agda 2.7.0.1 download step under it. `debian:13-slim` has no `curl`, so the job exited with code 127. The merge also dropped the checkout step. This PR restores #3's job (`76c1970`) verbatim. - **R reference oracle:** loading RCall exits with code 1 and prints nothing. The job now runs one step at a time: R loads ALDEx2, Julia starts R through RCall (with RCall's build log printed), and the extension loads. The comparison runs only after those pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_019Y6e175rh1LbrsEhQvCrJ1 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
What
Moves the proof gate from Agda 2.7.0.1 + a vendored agda-stdlib 3.0-dev SHA to the estate standard: Debian 13's
agda-bin=2.6.4.3-1+b2andagda-stdlib=2.1-4inside the digest-pinneddebian:13-slimimage, the same recipe as MetaManifold-Evidence and residual-evidence-types.Rebased onto #2 (
320513d, merged 2026-10-02T14:52Z). #2 broughtBenjaminiHochberg/StepUp.agdaand the 18-control gate self-test; this PR keeps both as they are onmainand re-applies only the toolchain change on top. The two files that conflicted (proofs/PROOF-STATUS.md,proofs/tests/gate-selftest.sh) were resolved by takingmain's version and re-applying the toolchain edits;README.mdmerged cleanly.Measured
_≡?_on ℤ →_≟_(three sites inPrelude.agda).StepUp.agdaneeds nothing. Every other imported module and name exists in 2.1.PROOF-STATUS.mdclaimed the proofs "do not compile against v2.4 or v2.1". That was false; the line is replaced with the measured port note.PATHto showlib.shresolves/usr/bin/agdaahead of it:Pkg.test(): 43/43, including the mutants intest/mutants.jl.Files
proofs/lib.sh(new) — toolchain resolution; dies naming what it found.proofs/check.sh(new) — the gate in CI order; replacesproofs/bootstrap.sh, which is deleted along with the vendoring and.agda-librariesmachinery.proofs/tests/gate-selftest.sh—main's 18 controls unchanged; the bootstrap-based resolver block is replaced by sourcinglib.sh, and the libraries file is written bywrite_libraries..github/workflows/ci.yml—proofsjob rewritten to the Debian container recipe.README.md,proofs/PROOF-STATUS.md(toolchain paragraphs and a fresh "Last verified" block),.gitignore,proofs/.gitignore.Merge
No required contexts on
main(rules/branches/mainis empty), so automerge is deliberately not armed; held for a human squash merge once the checks are green.🤖 Generated with Claude Code
https://claude.ai/code/session_01AjVQUkziVYywrLNsbPordh