Repository navigation
test: correct three expectations that failed CI on PR 69 - #322
hyperpolymath merged 1 commit into
Conversation
The `Julia tests` job fails on this branch with 9 failures (run 42435863478). All 9 are in tests that #312 added without a Julia run. In each case the code is right and the expectation is wrong. - Quoted-column filters. The response has one entry per sample, and each sample has its own count for the one remaining feature. The test read all four counts, and their sum, from the first sample. It now checks every sample by label: 2, 20, 200 and "9007199254740993". - Numeric count filter. The test sent `max` as 9007199254740993 and expected the 422 count-filter refusal. The request parser refuses an unsafe integer token first, with 400. The test now sends a safe bound for the 422 case and asserts the 400 for the unsafe token. - Unreadable derived record. The test read a directory and expected an I/O error. In Julia, `read` on a directory returns no bytes and raises nothing. The test now uses a Unix-domain socket path, whose open fails for every user, so the "cannot read existing derived analysis" branch runs. This also covers `derived_analyses.jl` line 79. No production code changes. Julia 1.12.5: `test/runtests.jl test_derived_analyses.jl test_validated_statistics.jl` gave 487 pass and 9 fail before, and gives 528 pass and 0 fail now. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZoTPXfxg1C85rVNx78
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
|
e5fd783
into
codex/issue-65-descriptive-statistics
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Change and reason
The
Julia testsjob fails on JoshuaJewell/MetaManifold-WebUI#69 at head1e58411: 6590 pass, 9 fail (run 42435863478). All 9 failures are in tests that hyperpolymath/MetaManifold-WebUI#312 added without a Julia run. In each case the code is right and the test expectation is wrong.test_validated_statistics.jl, 6 failures). The response has one entry per sample. Each sample has its own count for the one remaining feature. The test read all four counts, and their sum, from the first sample. It now checks every sample by label:2,20,200and"9007199254740993".maxas9007199254740993and expected the 422 count-filter refusal. The request parser refuses an unsafe integer token first, with 400. The test now sends a safe bound for the 422 case, and it asserts the 400 for the unsafe token.test_derived_analyses.jl, 1 failure). The test read a directory and expected an I/O error. In Julia,readon a directory returns no bytes and raises nothing. The test now uses a Unix-domain socket path. Its open fails for every user, root included.No production code changes. This pull request targets the branch of upstream PR 69. A merge here updates that pull request.
Validation
Julia 1.12.5, from the repository root:
1e58411: 487 pass, 9 fail. These are the same 9 failures as in CI.[2],[20],[200]and["9007199254740993"].read(directory)returnsUInt8[], andread(socket path)raisesSystemError.Not run: the full suite, the integration and server tests, and the frontend tests. No workflow runs on this pull request, because
ci.ymlon this branch starts only for pull requests intomain. The upstream CI runs after the merge.Scope
src/analysis/derived_analyses.jlline 79, which CI listed as a coverage gap.src/server/routes/validated_statistics.jl229 and 230: the catch around_body_filter_params.src/server/routes/validated_statistics.jl296: a floattime_limit_seconds.src/analysis/derived_analyses.jl127: the lost hardlink race.src/canonical.jl220: this branch looks unreachable, becausereprof a finiteFloat64always contains a..Contribution checks
1e58411) and contains no merges from fork main.Generated by Claude Code