Repository navigation
ci(secret-scan): call the scanner in proven-cicd-and-workflows - #83
Merged
Merged
Conversation
The caller named the reusable workflow of the standards repository. The Actions rule of this repository refuses a reusable workflow of a different owner, so the secret scan did not run. The caller now names hyperpolymath/proven-cicd-and-workflows at 1fd5e63, the commit that echidnabot and gitbot-fleet call. The owner is the same, so the rule permits it with no setting change. - job id stays `scan` (the called workflow checks it) - `fast-pr: false`: each run scans the full history - no `secrets:` line; `contents: read` is the whole grant - README.adoc: the lines on secret scanning name the new source Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZmiFSCoB3UR9Kk56rK
Contributor
|
Caution Review failedThe pull request is closed.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
The secret scan of this repository does not run.
secret-scanner.ymlcalls a reusable workflow of the standards repository, and the Actions rule of this repository refuses a reusable workflow of a different owner.This PR points the caller at
hyperpolymath/proven-cicd-and-workflowsat1fd5e63. That is the commit that echidnabot (hyperpolymath/echidnabot#205) and gitbot-fleet call. The owner is the same as the owner of this repository, so the rule permits the call with no setting change.Changes
secret-scanner.yml:uses:nameshyperpolymath/proven-cicd-and-workflows/.github/workflows/secret-scanner-reusable.yml@1fd5e6371a50f0fc3687206a5adca0cdf7b39aa6.scan. The called workflow reads the caller file and refuses a different job id or a pin that is not a full SHA.fast-pr: false: each run scans the full history.contents: readonly. The called workflow requests nothing more.concurrency:key do not change. The called workflow has noconcurrency:key.README.adoc(workflows): the lines on secret scanning name the new source.RSR Quality Checklist
Required
just testor equivalent): not run, the change is 1 workflow file and 1 documentjust fmtor equivalent): not run, same reasonunsafeblocks without// SAFETY:commentsbelieve_me,unsafeCoerce,Obj.magic,Admitted,sorry).envfiles includedAs Applicable
.github/workflows/README.adocTesting
uses:line matches the pattern that the called workflow applies to its caller (checked with the same regular expression).yqparses the file.1fd5e63: the called workflow has the jobsgitleaks,rust-secretsandshell-secrets, declares noworkflow_callsecret, and requestscontents: readonly.Not verified before the push:
Generated by Claude Code