Skip to content

ci(labels): timeout-minutes on the 2 label jobs - #88

Merged
hyperpolymath merged 1 commit into
mainfrom
claude/label-job-timeouts
Nov 10, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
claude/label-job-timeouts

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Hypatia reports 4 findings on 2 jobs of this repository:

Rule File Job
missing_timeout_minutes and WH006 .github/workflows/labels.yml sync
missing_timeout_minutes and WH006 .github/workflows/label-triage.yml triage

A job with no timeout-minutes can run for 6 hours.

Changes

  • labels.yml, job sync: timeout-minutes: 10.
  • label-triage.yml, job triage: timeout-minutes: 10.

10 minutes is the value that the estate template (hyperpolymath/rsr-template-repo) has for the same 2 jobs. Each job makes a small number of gh calls.

Not changed: the template also has runs-on: ubuntu-24.04 and GH_TOKEN: ${{ github.token }} in these 2 files. Those 2 differences are not a part of this PR.

RSR Quality Checklist

Required

  • Tests pass (just test or equivalent): not run, the change is 2 lines in 2 workflow files
  • Code is formatted (just fmt or equivalent): not run, same reason
  • Linter is clean (no new warnings or errors): not run locally, the PR checks give the result
  • No banned language patterns (no TypeScript, no npm/bun, no Go/Python)
  • No unsafe blocks without // SAFETY: comments
  • No banned functions (believe_me, unsafeCoerce, Obj.magic, Admitted, sorry)
  • SPDX license headers present on all new/modified source files
  • No secrets, credentials, or .env files included

As Applicable

None of the listed documents changes.

Testing

  • yq reads timeout-minutes=10 for the 2 jobs.
  • A scan of each workflow file with yq finds 0 jobs that run steps and have no timeout-minutes.

Not verified before the push:

  • The Hypatia count. The findings artifact of the Hypatia Security Scan run on this pull request must no longer list missing_timeout_minutes or WH006 for these 2 files. labels.yml and label-triage.yml themselves do not run on a pull request of this kind (label sync and issue triage), so their first runs come later.

Generated by Claude Code

Hypatia reports 4 findings on these 2 jobs: missing_timeout_minutes and
WH006 for job `sync` in labels.yml and for job `triage` in
label-triage.yml. A job with no timeout can run for 6 hours.

Each job gets `timeout-minutes: 10`, the value of the estate template
(hyperpolymath/rsr-template-repo). After this change, each job of this
repository that runs steps has a timeout.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmiFSCoB3UR9Kk56rK
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Chores
    • Added a 10-minute time limit to the label triage and label synchronisation jobs.

The triage and sync jobs in the label-related GitHub Actions workflows now have a 10-minute timeout.

Changes: Label workflow timeouts

Layer / File(s) Summary
Set job timeouts
.github/workflows/label-triage.yml, .github/workflows/labels.yml
The triage and sync jobs now have a 10-minute timeout.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to 901fa

Both label jobs gain a 10-minute limit. No merge-blocking risk is identified, though their first workflow runs are still pending.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly identifies the CI label jobs and the timeout change.
Description check Passed The description covers the summary, changes, quality checklist and testing. It explains which checks were not run and notes that screenshots and listed documentation updates do not apply.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5aa8e0d2-0704-4c0b-9c25-25e848fc4a93
Commits

Reviewing files that changed from the base of the PR and between 7ad7d87 and 901fa2c.

Files selected for processing: 2

  • .github/workflows/label-triage.yml
  • .github/workflows/labels.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 2

  • GitHub Check: CodeRabbit
  • GitHub Check: lint-workflows
Additional context used

Code guidelines: 1

.github/copilot-instructions.md — auto-discovered
Path-based instructions: 1

Source excerpt: Never use AGPL-3.0.

CodeRabbit inference engine (.github/copilot-instructions.md)

Files:

  • .github/workflows/label-triage.yml
  • .github/workflows/labels.yml
Additional comments: 2

.github/workflows/label-triage.yml: 1

49-49: LGTM!

.github/workflows/labels.yml: 1

35-35: LGTM!

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 10, 2026 22:13
@hyperpolymath
hyperpolymath merged commit c219f5b into main Nov 10, 2026
33 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T22:13:07.636881Z
We couldn’t complete this review. Comment @codex review to try again.
901fa2c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath deleted the claude/label-job-timeouts branch November 10, 2026 22:13
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants