Skip to content

docs(clade): uuid follows the GitHub path; qualify the prefixed-name case - #226

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/clade-uuid-github-path
Nov 11, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/clade-uuid-github-path

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Comment-only follow-up. An earlier PR replaced "uuid is immortal" in the CLADE status comment with "uuid follows the forge path". This one makes it exact. gv-clade-index ADR 0007 (accepted 2026-11-10) derives the uuid from the GitHub path (UUIDv5 over github.com/<owner>/<name>): a move or rename on GitHub mints a new one, and a mirror move or a phase change never does.

A2ML is retired for new content. Correcting a factually wrong comment in an existing file is an edit, not new content.

Changes

  • .machine_readable/CLADE.a2ml: "uuid follows the forge path" → "uuid follows the GitHub path (a move or rename there mints a new one, gv-clade-index ADR 0007; a mirror move or a phase change never does)"; "A prefixed-name (clade code) change is NOT a phase change" → "A prefixed-name (clade code) change with the GitHub path unchanged is NOT a phase change". The paragraph is re-wrapped at 80 columns. No data values change. The owner approved this wording for the whole estate. It refines the wording merged earlier.

RSR Quality Checklist

Required

  • Tests pass (just test or equivalent): not run locally. Comment-only change, left to CI.
  • Code is formatted (just fmt or equivalent): n/a, no code
  • Linter is clean (no new warnings or errors): n/a, no code
  • No banned language patterns
  • No unsafe blocks without // SAFETY: comments
  • No banned functions
  • SPDX license headers present on all new/modified source files (not touched)
  • No secrets, credentials, or .env files included

Testing

The diff is one comment paragraph in one file. Every line is ≤80 characters. The commit is signed.


Generated by Claude Code

The uuid is UUIDv5 over github.com/<owner>/<name> (gv-clade-index ADR
0007), so say "GitHub path" rather than "forge path": a move or rename on
GitHub mints a new uuid, a mirror move does not. Scope the "not a phase
change" sentence to a prefixed-name change with the GitHub path unchanged.

Correcting a factually wrong comment in an existing A2ML file is an edit,
not new A2ML content.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmTcNdC1jL1Vp3qW9H
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Clarified that UUID identity is based on the GitHub path. Moving a mirror or changing its lifecycle phase does not change the UUID.
    • Clarified that changing a prefixed name while keeping the same GitHub path records the previous name as an alias, without changing the UUID or phase.

The lifecycle-status comments now identify the GitHub path as the basis for UUID identity. They distinguish mirror moves from GitHub-path changes and clarify alias handling for prefixed-name changes. The changes update comments only; they do not change implementation.

Changes: Lifecycle identity comments

Layer / File(s) Summary
Clarify UUID identity rules
.machine_readable/CLADE.a2ml
The comments state that mirror moves and phase changes do not mint a UUID. If a prefixed name changes while the GitHub path stays the same, the old name goes to aliases[], with no UUID or phase change.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

  • hyperpolymath/bofig#225: Updates the same lifecycle-status comments about UUID changes for moves, renames, and phase changes.
Merge Risk: Minimal · up to c414d

The change clarifies UUID identity without changing code or data. No material merge risk is evident.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly describes the change to UUID identity wording and the prefixed-name case.
Description check Passed The description explains the comment changes, their rationale, and the testing status. It relates directly to the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 091da41c-9bc3-416b-b1df-c488ea0497d0
Commits

Reviewing files that changed from the base of the PR and between fd95f82 and c414d42.

Files selected for processing: 1

  • .machine_readable/CLADE.a2ml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 14

  • GitHub Check: CodeRabbit
  • GitHub Check: analyze (javascript-typescript, none)
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: Groove manifest check
  • GitHub Check: Validate DEED manifests
  • GitHub Check: Validate K9 contracts
  • GitHub Check: analyze (actions, none)
  • GitHub Check: Validate eclexiaiser manifest
  • GitHub Check: Hypatia Neurosymbolic Analysis
  • GitHub Check: build
  • GitHub Check: security
  • GitHub Check: Build and test
  • GitHub Check: SonarQube
  • GitHub Check: semgrep-cloud-platform/scan
Additional comments: 1

.machine_readable/CLADE.a2ml: 1

29-35: LGTM!

@linear-code
linear-code Bot marked this pull request as ready for review November 10, 2026 23:54
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T23:55:10.935756Z c414d42 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

CI note: four checks are failing on this PR, and all four also fail on the latest main commit (fd95f82), so this PR did not cause them:

  • Build and test
  • Hypatia Neurosymbolic Analysis
  • analyze (actions, none)
  • analyze (javascript-typescript, none)

This PR only changes a comment in .machine_readable/CLADE.a2ml. I don't have a fix to port in, and I can't re-run the checks from here.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Follow-up: the security check has now failed on this PR too. It also fails on main (fd95f82), so this PR did not cause it either.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Follow-up: Validate eclexiaiser manifest has now failed on this PR too. It also fails on main (fd95f82), so this PR did not cause it either.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Follow-up: SonarQube has now failed on this PR as well. It also fails on main (fd95f82), so this PR did not cause it either.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Follow-up: three more checks have failed on this PR: Validate K9 contracts, Groove manifest check and Validate DEED manifests. All three also fail on main (fd95f82), so this PR did not cause them either.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Follow-up: Empty-linter (invisible characters) has now failed on this PR. It also fails on main (fd95f82). I checked this PR's diff: the only non-ASCII character in it is the em dash (—), which was already in the line being replaced. There are no invisible characters, so the failure does not come from this PR.


Generated by Claude Code

Copy link
Copy Markdown
Owner Author

Follow-up: build has also failed on this PR. It fails on main (fd95f82) as well, so this PR did not cause it either.


Generated by Claude Code

@hyperpolymath
hyperpolymath merged commit 6271643 into main Nov 11, 2026
3 of 16 checks passed
@hyperpolymath
hyperpolymath deleted the docs/clade-uuid-github-path branch November 11, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants