Skip to content

docs(clade): uuid follows the forge path, it is not immortal - #93

Merged
hyperpolymath merged 1 commit into
mainfrom
chore/uuid-not-immortal
Nov 10, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
chore/uuid-not-immortal

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Comment-only correction in .machine_readable/CLADE.a2ml. The status comment said the uuid is immortal. gv-clade-index ADR 0007 (accepted 2026-11-10) makes the uuid follow the forge path: a move or rename mints a new one, and a phase change never does. The comment's "A rename is NOT a phase change" now says "A prefixed-name (clade code) change", the rename it means. Paragraph re-wrapped at 80 columns; no data value changes.


Generated by Claude Code

Comment-only correction. The CLADE status comment written by
clade-status-backfill (gv-clade-index ADR 0006) said the uuid is
immortal. gv-clade-index ADR 0007, accepted 2026-11-10, makes the uuid
follow the forge path: a move or rename mints a new one, and a phase
change never does. The same comment's "A rename is NOT a phase change"
now says "A prefixed-name (clade code) change", the rename it means, so
the two sentences no longer read as a contradiction. No data value
changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmtCj9Doze7s38qbz5
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Summary

Summary by CodeRabbit

  • Documentation
    • Clarified how UUIDs behave when an item is moved, renamed, or changes phase. UUIDs follow the forge path and are newly minted on a move or rename; a phase change leaves the UUID unchanged.
    • Clarified that changing a prefixed name adds the previous name to aliases[] without changing the UUID or phase.

The lifecycle comment now describes UUID handling for moves and renames. It distinguishes these from prefixed-name changes, which add the old name to aliases[] without changing the UUID or phase.

Changes: Lifecycle documentation

Layer / File(s) Summary
Revise lifecycle comment
.machine_readable/CLADE.a2ml
The comment states that UUIDs follow the forge path and are newly minted on a move or rename. It says a prefixed-name change adds the old name to aliases[] without changing the UUID or phase.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · up to dea4b

The comment clarifies UUID and phase handling. No concrete merge-blocking impact was established.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly describes the UUID lifecycle correction documented in the pull request.
Description check Passed The description explains the comment changes and the UUID behaviour they document.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1

.machine_readable/CLADE.a2ml-29-30: 1

29-30: Minor · Data Integrity & Integration · Quick win

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Specify the primary forge path.

A rename of the GitLab mirror does not change the GitHub path, so it does not change the UUID derived from that path. The current wording can suggest that any forge move or rename requires a new UUID. Limit this rule to the primary forge path. (raw.githubusercontent.com)

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 249b2183-ff0d-484b-a6f1-df7b76edd6ab
Commits

Reviewing files that changed from the base of the PR and between f8d8624 and dea4b72.

Files selected for processing: 1

  • .machine_readable/CLADE.a2ml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Review details

Context from checks skipped due to timeout: 7

  • GitHub Check: CodeRabbit
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Groove manifest check
  • GitHub Check: Validate DEED manifests
  • GitHub Check: analyze (actions, none)

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 10, 2026 21:05
@hyperpolymath
hyperpolymath merged commit cbd8445 into main Nov 10, 2026
8 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants