Repository navigation
fix(abi): CapnSchemas proved its claims about implicit variables; qualify, gate it in the ipkg #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
20dc691
fix(deps): move rmcp to 3.9.0 off three RustSec advisories
claude 17ebbb1
style: rustfmt src/rust/proof_search.rs
claude f48fe0a
fix(ffi): annotate the audited Zig context-pointer casts for Hypatia
claude b00eec3
Merge remote-tracking branch 'origin/claude/new-session-th4e9w-fmt-pr…
claude 1e0d68a
Merge remote-tracking branch 'origin/claude/new-session-th4e9w-zig-ca…
claude 4dab099
fix(abi): CapnSchemas proved its claims about implicit variables; qua…
claude 1013f3b
Merge remote-tracking branch 'origin/claude/new-session-th4e9w-rustse…
claude d34d0ef
Merge branch 'main' into claude/new-session-th4e9w-abi-capnschemas
hyperpolymath 1d0d8b6
Merge branch 'main' into claude/new-session-th4e9w-abi-capnschemas
hyperpolymath File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When downstream ABI code imports the newly packaged module, it receives an incorrect
echidnaSchemaId:schemas/echidna.capnp:12declares0xd3b45f8ae1c79012, whose decimal value is15254922887908790290, whileCapnSchemas.idr:37exports15242516543891767314(0xd3884c09d1af0012). The new nonzero proof still succeeds because it proves only that this mismatched value is not zero, so consumers relying on the mirror for schema identification can use an incompatible ID; correct the constant before adding the module to the package.Useful? React with 👍 / 👎.