You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(test): stop executable fixtures racing ETXTBSY under parallel tests - #487
provers::chuffed::tests::version_rejects_failed_empty_or_stderr_only_help
Failed to execute fzn-chuffed --help: Text file busy (os error 26)
It failed on #470, whose diff contains no Rust, and earlier in llvm-cov. The cause is a real race, not a flake. Four fixtures (chuffed, faial, gpuverify and version_probe) each write a shell script and execute it at once. If another test thread forks while the write descriptor is still open, the child keeps a copy of it until it reaches exec (Rust opens files close-on-exec). While any writer exists, the kernel refuses to execute the file with ETXTBSY.
Fix
New test-only helper, provers::test_fixture::write_executable (cfg(all(test, unix))). It:
creates the script with mode 0700 and closes it;
runs it with a sentinel argument until the kernel accepts the exec (up to 2 s, then it panics).
After one successful exec, no writer remains and no later fork can inherit one, so the test's own spawn cannot hit ETXTBSY. Every fixture script exits 64 on an unexpected argument, so the probe never runs a fixture body. The four fixtures now use the helper.
The PR also carries #465's rustfmt fix to proof_search.rs, byte-identical to it, so cargo fmt --check is green here as well.
Checks run locally
cargo test --lib -- provers::chuffed provers::faial provers::gpuverify provers::version_probe: 58 passed.
cargo clippy --lib --tests -- -D warnings: clean.
cargo fmt --check: clean.
Once this is open, I'll port it into the open PRs that hit the race (starting with #470).
`provers::chuffed::tests::version_rejects_failed_empty_or_stderr_only_help`
failed in CI with "Failed to execute fzn-chuffed --help: Text file busy
(os error 26)". The fixtures wrote a script and executed it at once. A fork
on another test thread, taken while the write descriptor was open, keeps
a copy until that child execs, and the kernel refuses to execute a file
with a writer.
New provers::test_fixture::write_executable creates the script with mode
0700, closes it, then runs it with a sentinel argument until the kernel
accepts the exec. After one successful exec no writer remains and no
later fork can inherit one. The chuffed, faial, gpuverify and
version_probe fixtures use it; each fixture exits 64 on an unexpected
argument, so the probe runs no fixture body.
Also carries the rustfmt fix to proof_search.rs from #465, identical to
it, so `cargo fmt --check` is green here.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
No actionable comments were generated in the recent review.
Summary
Summary by CodeRabbit
Chores
Fixture scripts now have their executable permissions set explicitly. If permissions cannot be updated, the operation reports an error. The existing execution checks and retry behaviour are unchanged. This is an internal reliability update and does not change any user-facing features or behaviour.
The fixture writer now sets the script permissions to 0o700 after writing it. Permission-setting failures panic with make fixture executable. The existing execution probe and retry behaviour are unchanged.
Changes: Executable fixture permissions
Layer / File(s)
Summary
Write and set fixture permissions src/rust/provers/test_fixture.rs
The fixture writer imports PermissionsExt and sets the script permissions to 0o700 after writing it. It panics with make fixture executable if setting permissions fails.
hyperpolymath/echidna#455: Adds version-probe tests for Faial and GpuVerify; this PR updates executable fixtures used for those backends.
Merge Risk: Minimal · up to 54c7e
Fixture scripts receive explicit owner-only executable permissions. No material merge risk is evident.
Pre-merge checks: 5
Check name
Status
Explanation
Title check
The title clearly describes the change: preventing ETXTBSY failures in parallel tests that use executable fixtures.
Description check
The description explains the problem, fix, and test results. It does not include the template’s RSR Quality Checklist or Screenshots sections, but the main required information is present.
Docstring Coverage
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 2f5209be-bb42-42ba-b63f-3eb33024de4a
Commits
Reviewing files that changed from the base of the PR and between 2cb8ceb and 54c7e3f.
Files selected for processing: 1
src/rust/provers/test_fixture.rs
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.
Review on #487: OpenOptions::mode is filtered by the process umask, so a
restrictive umask could leave the fixture non-executable. Restore the
explicit set_permissions(0o700) after closing the writer and before the
readiness probe.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019a95kk88TZ1iegsBK3kox3
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Problem
rust-ci / Cargo testfailed intermittently with:It failed on #470, whose diff contains no Rust, and earlier in llvm-cov. The cause is a real race, not a flake. Four fixtures (chuffed, faial, gpuverify and version_probe) each write a shell script and execute it at once. If another test thread forks while the write descriptor is still open, the child keeps a copy of it until it reaches
exec(Rust opens files close-on-exec). While any writer exists, the kernel refuses to execute the file withETXTBSY.Fix
New test-only helper,
provers::test_fixture::write_executable(cfg(all(test, unix))). It:0700and closes it;exec(up to 2 s, then it panics).After one successful
exec, no writer remains and no later fork can inherit one, so the test's own spawn cannot hitETXTBSY. Every fixture script exits 64 on an unexpected argument, so the probe never runs a fixture body. The four fixtures now use the helper.The PR also carries #465's rustfmt fix to
proof_search.rs, byte-identical to it, socargo fmt --checkis green here as well.Checks run locally
cargo test --lib -- provers::chuffed provers::faial provers::gpuverify provers::version_probe: 58 passed.cargo clippy --lib --tests -- -D warnings: clean.cargo fmt --check: clean.Once this is open, I'll port it into the open PRs that hit the race (starting with #470).
Generated by Claude Code