Skip to content

fix(ci): rename the suite call and refresh actions.lock after PR 491 - #496

Merged
hyperpolymath merged 2 commits into
mainfrom
marina/optimistic-cray-js64k7
Nov 10, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
marina/optimistic-cray-js64k7

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

PR 491 moved security-scan.yml to panic-attack 55ffcc9, but actions.lock still records be6ac46. The official refresh could not fix that: it failed on main too (run 42869749661, "close-lock: 3 ref(s) could not be resolved"). The cause is zig-ffi-ci.yml, which still calls the suite as hyperpolymath/cicd-suite. The tool rewrites the call to the renamed repository, drops the old record, and then cannot write it again.

Changes

  • .github/workflows/zig-ffi-ci.yml: the call names hyperpolymath/proven-cicd-and-workflows. The commit 4c772eb does not change, and it is an ancestor of that repository's main.
  • .github/workflows/actions.lock: the official refresh candidate from run 42873771915, applied without edits. It moves the Security Scan record to 55ffcc9, renames the suite record, and prunes the entry of the deleted boj-build.yml.

RSR Quality Checklist

Required

  • Tests pass: no code changes. The refresh run passed Check workflow policy and issue regressions.
  • Code is formatted
  • Linter is clean
  • No banned language patterns
  • No unsafe blocks without // SAFETY: comments
  • No banned functions
  • SPDX license headers present (unchanged)
  • No secrets, credentials, or .env files included

As Applicable

  • None applies.

Testing

  • Run 42873771915 (workflow_dispatch, refresh_actions_lock: true) at cb0f560: canonical outcome changed, close-lock 0 dangling refs, update-actions-lock.sh --verify-local accepted, check-lock-sync.sh: "actions.lock is in sync".
  • The patch from that run applies with git apply --check and is the only change in the second commit.

Screenshots

Not applicable.


Generated by Claude Code

hyperpolymath/cicd-suite is renamed to proven-cicd-and-workflows. The
official actions.lock refresh rewrites this call to the new name, drops
the old record, and then cannot close the lock (run 42869749661:
"close-lock: 3 ref(s) could not be resolved"). The commit 4c772eb stays.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6
Signed-off-by: Claude <noreply@anthropic.com>
Applied without edits from the "Prepare official actions.lock refresh
candidate" step of run 42873771915 (outcome: changed; close-lock: 0
dangling refs; check-lock-sync: in sync). It moves the Security Scan
record from panic-attack be6ac46 to 55ffcc9 (PR 491), renames the suite
record to proven-cicd-and-workflows, and prunes the entry of the deleted
boj-build.yml.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6
Signed-off-by: Claude <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f3f95739-59c5-4589-b579-e31f964ee81e
Commits

Reviewing files that changed from the base of the PR and between 7cb26bf and d97e6c2.

Files ignored due to path filters: 1

  • .github/workflows/actions.lock is excluded by !**/*.lock
Files selected for processing: 1

  • .github/workflows/zig-ffi-ci.yml
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 10, 2026 18:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T18:30:50.288409Z d97e6c2 Draft marked ready
🔒 Security Review ❌ Failed 2026-11-10T18:28:54.273575Z
We couldn’t complete this review. Comment @codex security review to try again.
d97e6c2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@hyperpolymath
hyperpolymath enabled auto-merge (squash) November 10, 2026 18:28
Repository owner deleted a comment from chatgpt-codex-connector Bot Nov 10, 2026
@hyperpolymath
hyperpolymath merged commit 453fe3b into main Nov 10, 2026
73 checks passed
@hyperpolymath
hyperpolymath deleted the marina/optimistic-cray-js64k7 branch November 10, 2026 18:36
hyperpolymath pushed a commit that referenced this pull request Nov 10, 2026
#496 refreshed actions.lock on main. Take main's lockfile, then
regenerate it with gh-actions-lock v0.2.0 --no-onboard --no-narrow, so
the only change against main is removing the 8 reusable-workflow
entries that v0.2.0 reports as unused. No workflow file changes;
--verify-local: all 34 workflows have complete lockfile coverage.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZnmBahbhfkFEP6ark4
hyperpolymath added a commit that referenced this pull request Nov 10, 2026
## Summary

The Workflow Security Linter refresh and the committed `actions.lock`
produced different locks. This PR makes them agree, using the form the
owner chose: the form that the standards refresh tool writes.

The candidate is applied without edits, from the "Prepare official
actions.lock refresh candidate" step of run 42897428598 on `18828c3`.
That run reports `close-lock: 0 dangling refs`, `prune-stale: oracle
vetoes 0` and `actions.lock is in sync`. It restores the
reusable-workflow records that #495 removed: 8 job-level reusable calls,
with their transitive actions.

## Why this is safe for governance

#495 removed these records as stale. The governance gate accepts them,
however. Its verifier (standards `a797d30`,
`scripts/update-actions-lock.sh`, `verify_lock_coverage`) accepts a
`stale` finding when the workflow calls that exact
`owner/repo/.github/workflows/…@ref`. The governance log on `d98b0e2`
shows that 7 of the 8 records were accepted. It rejected only 1:
`security-scan.yml → panic-attack@be6ac46`, which was stale because #491
had moved the call to `55ffcc9`. This form passed governance on
`453fe3b` (#496).

The refresh run above printed the same "Accepted reusable-workflow lock
coverage" line for each of the 8 current calls.

## Correction

#500 said that applying this candidate would turn governance red. That
was wrong, for the reason above.

## Test plan

- [ ] governance / Actions lockfile verify passes on this head.

---
_Generated by [Claude
Code](https://claude.ai/code/session_0136P7ZmAsYpFA9gxfQLF3F6)_

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants