Repository navigation
chore: drop * wildcard from CODEOWNERS to stop Dependabot review pings - #58
Merged
Merged
Conversation
hyperpolymath
added a commit
that referenced
this pull request
May 14, 2026
Replaces the local copy of `.github/workflows/hypatia-scan.yml` with the canonical version from upstream main. The old copy had three issues that combined to break every Dependabot PR: 1. `working-directory: \${{ env.HOME }}/hypatia\``, where `env.HOME` is not a GHA context — it evaluated to empty, so `cd /hypatia` failed and the scanner was never built. 2. `hypatia-cli.sh scan .` without `--exit-zero` — scanner exit-1 on findings short-circuited the rest of the step under `set -e`. 3. No baseline gate, so any pre-existing critical/high failed the build. Upstream version: - captures scanner exit code + stderr (visible on crash) - falls back to `[]` on missing/invalid JSON - reads `.hypatia-baseline.json` and fails only on NET-NEW critical/high - scopes permissions narrowly (contents: read, pull-requests: write) - marks the PR-comment step `continue-on-error: true` so Dependabot PRs (read-only token) don't fail on the unavoidable 403 Baseline file follows in a second commit on this branch — first we need the new workflow to actually run and capture current findings. Unblocks PR #58 (CODEOWNERS) which is stuck on this exact scan. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
8 of 9 tasks
hyperpolymath
added a commit
that referenced
this pull request
Nov 9, 2026
…pre-split goldens (#483) ## Summary This is the W0 "split" lane. It is stacked on #475, which carries the gate it is checked against. Three hotspot files are broken into modules by area. Behaviour is held fixed by goldens captured on the pre-split tree, and W0 exit check 5 compares them. Nothing is renamed or redesigned. ## Changes - **Goldens first** (535274c). `tests/golden/hotspot/` holds 27 files captured before any move: every route, the router composition, and `--help` for each CLI command and subcommand. `scripts/gates/hotspot-goldens.sh` regenerates them and compares. - **`src/rust/server.rs` → `server/{mod,agent,prove,search,session,status,ui,verify}.rs`** (a2fb862). Handlers move by route family. `mod.rs` keeps router composition and shared state. - **`src/rust/main.rs` → `cli/{args,util,prove,verify,search,session,provers,lexicon,corpus,design}.rs`** (ee2ed98). `main.rs` keeps only parsing, tracing set-up and dispatch; `cli/mod.rs` re-exports the command functions. - **`Justfile` → `just/*.just`** (9444837). There are 14 files, one per area, pulled in by `import`. The contractile import stays last. Recipe names and bodies are unchanged; `just --list` matches before and after. - **Merged from #475's base:** the #465 fix for the red checks on `main` (rmcp 3.9.0, rustfmt on `proof_search.rs`, and the Zig-cast annotations). ## RSR Quality Checklist ### Required - [x] Tests pass. W0 check 5 (hotspot goldens) passes, and so does `cargo check --bins` after the merge. I have not run the full `just test` on this branch: disk here is limited. This PR's CI runs it. - [x] Code is formatted (`cargo fmt --all -- --check` is clean). - [x] Linter is clean (`cargo clippy` was clean when the split landed). - [x] No banned language patterns. - [x] No new `unsafe`. - [x] No banned functions. - [x] SPDX headers on all new files. - [x] No secrets. ### As Applicable - [ ] Documentation: `CLAUDE.md`'s structure tree still lists `server.rs` and `main.rs`. That reconcile is reserved for the rulings lane (#58), so this PR does not edit `CLAUDE.md`. ## Testing - `bash scripts/gates/hotspot-goldens.sh check` exits 0: routes, router composition and CLI help are byte-identical to the pre-split capture. - `cargo check --bins` and `cargo fmt --all -- --check` pass on the merged head. - Already broken on the pre-split tree, and not changed here: `echidna corpus import-octads --help` panics (exit 101). It has its own follow-up. Refs #416 --- _Generated by [Claude Code](https://claude.ai/code/session_01WS4mfQeC3N1DWjcCQJaQqw)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The catch-all
* @hyperpolymathline in CODEOWNERS causes GitHub to auto-request review on every Dependabot PR (since every PR touches at least one owned path under*). With the sole maintainer being the same user, those review requests are pure notification noise.This drops the wildcard line while preserving any path-specific ownership and SPDX/license headers. Path-specific lines are intentional and stay.
Human PRs from collaborators still trigger path-owner review where applicable; Dependabot PRs typically only touch root manifest files which are no longer matched.