Repository navigation
docs: remove the statement that a bare clone does not build - #204
Conversation
3 documents said that `Cargo.toml` has a path dependency on `gitbot-shared-context` at `../../shared-context`, and that a build needs the gitbot-fleet layout. That is not true any more: `Cargo.toml` takes the crate as a git dependency with a `rev` pin, and a bare clone builds and runs its tests. The instructions file was corrected in #200. - `CONTRIBUTING.adoc`: the section "Workspace caveat" becomes "Build from a bare clone", with the true statement. The item `cargo test` in the checklist loses its caveat. - `RSR_COMPLIANCE.adoc`: the row for the path dependency goes out of the table of known deviations. The action item is marked as done. - `README.adoc`: 1 comment line in the build example. The 2 files named issue 18 as the tracker of the path dependency. Issue 18 is about another subject, so the new text names no issue. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZmiFSCoB3UR9Kk56rK
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Summary
3 documents said that
Cargo.tomlhas a path dependency ongitbot-shared-contextat../../shared-context, and that a build needs the gitbot-fleet layout. That is not true any more.Cargo.tomltakes the crate as a git dependency with arevpin (line 29), and a bare clone builds and runs its tests.#200 corrected the same statement in the instructions file. This pull request corrects the documents for people.
Changes
CONTRIBUTING.adoc: the section "Workspace caveat" becomes "Build from a bare clone", with the true statement. The 3 workarounds go out, because nothing needs a workaround. The checklist itemcargo testloses its caveat.RSR_COMPLIANCE.adoc: the row for the path dependency goes out of the table of known deviations. The action item "Resolvegitbot-shared-contextpath dependency" is marked as done.README.adoc: 1 comment line in the build example. It said "requires gitbot-fleet layout" and pointed toCONTRIBUTING.md. The file isCONTRIBUTING.adoc.The owner asked for
CONTRIBUTING.adocandRSR_COMPLIANCE.adoc. TheREADME.adocline has the same false statement and points to the section that changes here, so it is in this pull request too.The 2 files named issue 18 as the tracker of the path dependency. Issue 18 is about another subject (
rsa) and is closed, so the new text names no issue.Testing
cargo test --lockedran in this session with exit 0 (at1a6908e, Rust 1.99.0, the toolchain ofrust-toolchain.toml). No gitbot-fleet checkout was present.grepfor the old statement in*.adoc,*.md,*.a2mland*.tomlafter the change: the only hits are the 2 sentences that say the old statement is not true any more.RSR_COMPLIANCE.adocstill has its|===end line. I did not render the documents.Generated by Claude Code