Repository navigation
fix(ephapax): sweep .expect("TODO: handle error") — 116 sites - #32
Merged
Merged
Conversation
Replaced all 116 occurrences of .expect("TODO: handle error") across the codebase:
Policy breakdown:
- Test code (89 sites): converted to .unwrap() per test convention
- Production invariants (5 sites): added meaningful .expect() messages with "invariant:" prefix
- Parser sequencing: len() == 1 guarantees next() returns Some
- Match arm processing: len() == 2 and len() == 1 branches with explicit checks
- Parser tuple/list construction: invariant preconditions documented
- Error propagation (2 sites): replaced with proper error handling
- DAP Content-Length header: match to safely extract string
- DAP response JSON serialization: match to skip on serialization failure
- Registry lookups (2 sites): converted to ok_or_else() with UnknownType error
All changes maintain type safety and error semantics:
- cargo check: PASS
- cargo test --lib: 273/273 tests PASS (0 failures)
Files modified:
- src/ephapax-parser/src/{lib,lists_tuples,surface}.rs
- src/ephapax-desugar/src/lib.rs
- src/ephapax-package/src/{lib,manifest,registry,resolver}.rs
- src/ephapax-typing/src/lib.rs
- src/ephapax-vram-cache/src/lib.rs
- src/ephapax-wasm/src/debug.rs
- tools/ephapax-dap/src/main.rs
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive sweep of all
.expect("TODO: handle error")anti-patterns across the ephapax codebase.Total sites cleared: 116
Policy breakdown:
Verification:
🤖 Generated with Claude Code