Skip to content

docs(clade): uuid follows the GitHub path; qualify the prefixed-name case - #118

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/clade-uuid-github-path
Nov 10, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/clade-uuid-github-path

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Summary

Comment-only follow-up. An earlier PR replaced "uuid is immortal" in the CLADE status comment with "uuid follows the forge path". This one makes it exact. gv-clade-index ADR 0007 (accepted 2026-11-10) derives the uuid from the GitHub path (UUIDv5 over github.com/<owner>/<name>): a move or rename on GitHub mints a new one, and a mirror move or a phase change never does.

A2ML is retired for new content. Correcting a factually wrong comment in an existing file is an edit, not new content.

Changes

  • .machine_readable/CLADE.a2ml: "uuid follows the forge path" → "uuid follows the GitHub path (a move or rename there mints a new one, gv-clade-index ADR 0007; a mirror move or a phase change never does)"; "A prefixed-name (clade code) change is NOT a phase change" → "A prefixed-name (clade code) change with the GitHub path unchanged is NOT a phase change". The paragraph is re-wrapped at 80 columns. No data values change. The owner approved this wording for the whole estate. It refines the wording merged earlier.

RSR Quality Checklist

Required

  • Tests pass (just test or equivalent): not run locally. Comment-only change, left to CI.
  • Code is formatted (just fmt or equivalent): n/a, no code
  • Linter is clean (no new warnings or errors): n/a, no code
  • No banned language patterns
  • No unsafe blocks without // SAFETY: comments
  • No banned functions
  • SPDX license headers present on all new/modified source files (not touched)
  • No secrets, credentials, or .env files included

Testing

The diff is one comment paragraph in one file. Every line is ≤80 characters. The commit is signed.


Generated by Claude Code

The uuid is UUIDv5 over github.com/<owner>/<name> (gv-clade-index ADR
0007), so say "GitHub path" rather than "forge path": a move or rename on
GitHub mints a new uuid, a mirror move does not. Scope the "not a phase
change" sentence to a prefixed-name change with the GitHub path unchanged.

Correcting a factually wrong comment in an existing A2ML file is an edit,
not new A2ML content.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZmTcNdC1jL1Vp3qW9H
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Clarified that moving or renaming an item on GitHub changes its UUID, while moving a mirror or changing an item’s phase does not.
    • Clarified that changing the prefixed name without changing the GitHub path preserves the UUID and phase; the previous name is retained as an alias.

The lifecycle-status comments now define UUID identity by the GitHub path. They distinguish GitHub moves from mirror moves and clarify how prefixed-name changes affect aliases and phase.

Changes: Lifecycle identity

Layer / File(s) Summary
Clarify lifecycle identity rules
.machine_readable/CLADE.a2ml
The comments state that a GitHub move or rename creates a new UUID, while a mirror move or phase change does not. If the GitHub path stays the same, a prefixed-name change adds the old name to aliases[] and does not change the UUID or phase.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 234a8

The change clarifies identity rules without changing data values; no merge-blocking risk is evident.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly describes the UUID rule and the prefixed-name qualification in the changeset.
Description check Passed The description explains the comment changes and their rationale. It is related to the changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: b0fa62f7-2834-4546-93ac-a3a31799f369
Commits

Reviewing files that changed from the base of the PR and between 42ba3ec and 234a854.

Files selected for processing: 1

  • .machine_readable/CLADE.a2ml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Context from checks skipped due to timeout: 10

  • GitHub Check: CodeRabbit
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: analyze (actions, none)
  • GitHub Check: analyze (rust, none)
  • GitHub Check: Security Audit
  • GitHub Check: Validate DEED manifests
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Groove manifest check
  • GitHub Check: Code Coverage
  • GitHub Check: Empty-linter (invisible characters)
Additional comments: 1

.machine_readable/CLADE.a2ml: 1

29-35: LGTM!

@sonarqubecloud

Copy link
Copy Markdown

@linear-code
linear-code Bot marked this pull request as ready for review November 10, 2026 23:49

Copy link
Copy Markdown
Owner Author

CI note: the failing checks are not caused by this PR.

  • Security Audit fails at Run security audit. It also fails on the current main head (42ba3ec).
  • Test (macos-latest, beta) fails at Check formatting, which runs rustfmt from the beta toolchain over the Rust sources. On main this job was cancelled because Test (macos-latest, stable) failed first, so main is red on macOS too.

This PR changes one comment paragraph in .machine_readable/CLADE.a2ml and no Rust source, so neither the audit nor rustfmt sees a different input. There is no fix in main to port into this PR yet.


Generated by Claude Code

@hyperpolymath
hyperpolymath merged commit 7f9a357 into main Nov 10, 2026
12 of 20 checks passed
@hyperpolymath
hyperpolymath deleted the docs/clade-uuid-github-path branch November 10, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants